Skip to content

Commit 26a5c22

Browse files
committed
fix(metrics): update memory usage metrics to report in megabytes
1 parent 2c54308 commit 26a5c22

4 files changed

Lines changed: 16 additions & 16 deletions

File tree

src/sentry/src/Metrics/Listener/OnBeforeHandle.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,15 @@ public function process(object $event): void
9797

9898
metrics()->gauge(
9999
'memory_usage',
100-
(float) memory_get_usage(),
100+
memory_get_usage(true) / 1024 / 1024,
101101
['worker' => '0'],
102-
Unit::byte()
102+
Unit::megabyte()
103103
);
104104
metrics()->gauge(
105105
'memory_peak_usage',
106-
(float) memory_get_peak_usage(),
106+
memory_get_peak_usage(true) / 1024 / 1024,
107107
['worker' => '0'],
108-
Unit::byte()
108+
Unit::megabyte()
109109
);
110110
});
111111

src/sentry/src/Metrics/Listener/OnCoroutineServerStart.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,15 @@ public function process(object $event): void
108108

109109
metrics()->gauge(
110110
'memory_usage',
111-
(float) memory_get_usage(),
111+
memory_get_usage(true) / 1024 / 1024,
112112
['worker' => '0'],
113-
Unit::byte()
113+
Unit::megabyte()
114114
);
115115
metrics()->gauge(
116116
'memory_peak_usage',
117-
(float) memory_get_peak_usage(),
117+
memory_get_peak_usage(true) / 1024 / 1024,
118118
['worker' => '0'],
119-
Unit::byte()
119+
Unit::megabyte()
120120
);
121121
});
122122

src/sentry/src/Metrics/Listener/OnMetricFactoryReady.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,15 +120,15 @@ public function process(object $event): void
120120
);
121121
metrics()->gauge(
122122
'metric_process_memory_usage',
123-
(float) memory_get_usage(),
123+
memory_get_usage(true) / 1024 / 1024,
124124
['worker' => (string) $workerId],
125-
Unit::byte()
125+
Unit::megabyte()
126126
);
127127
metrics()->gauge(
128128
'metric_process_memory_peak_usage',
129-
(float) memory_get_peak_usage(),
129+
memory_get_peak_usage(true) / 1024 / 1024,
130130
['worker' => (string) $workerId],
131-
Unit::byte()
131+
Unit::megabyte()
132132
);
133133
});
134134

src/sentry/src/Metrics/Listener/OnWorkerStart.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,15 @@ public function process(object $event): void
110110
);
111111
metrics()->gauge(
112112
'memory_usage',
113-
(float) memory_get_usage(),
113+
memory_get_usage(true) / 1024 / 1024,
114114
['worker' => (string) ($event->workerId ?? 0)],
115-
Unit::byte()
115+
Unit::megabyte()
116116
);
117117
metrics()->gauge(
118118
'memory_peak_usage',
119-
(float) memory_get_peak_usage(),
119+
memory_get_peak_usage(true) / 1024 / 1024,
120120
['worker' => (string) ($event->workerId ?? 0)],
121-
Unit::byte()
121+
Unit::megabyte()
122122
);
123123
});
124124

0 commit comments

Comments
 (0)