Skip to content

Commit e2bebcf

Browse files
authored
refactor: remove unused ProjectRunnerSurface slots and toggle helper (goplus#2364)
This follows up on goplus#2331. Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
1 parent ef3f9f4 commit e2bebcf

2 files changed

Lines changed: 55 additions & 74 deletions

File tree

spx-gui/src/components/editor/preview/EditorPreview.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ function handleFullscreenChange(value: boolean) {
393393
394394
function handleEnterFullscreen() {
395395
if (runnerState.value === 'initial') return
396-
projectRunnerSurfaceRef.value?.toggleFullscreen(true)
396+
handleFullscreenChange(true)
397397
}
398398
399399
onBeforeUnmount(() => {

spx-gui/src/components/project/runner/ProjectRunnerSurface.vue

Lines changed: 54 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -376,10 +376,6 @@ function closeFullscreen() {
376376
emit('update:fullscreen', false)
377377
}
378378
379-
function toggleFullscreen(value?: boolean) {
380-
emit('update:fullscreen', value ?? !props.fullscreen)
381-
}
382-
383379
defineExpose({
384380
async run() {
385381
return runnerRef.value?.run()
@@ -389,8 +385,7 @@ defineExpose({
389385
},
390386
async rerun() {
391387
return runnerRef.value?.rerun()
392-
},
393-
toggleFullscreen
388+
}
394389
})
395390
</script>
396391

@@ -417,72 +412,59 @@ defineExpose({
417412
}"
418413
>
419414
<div v-if="overlayActive && (overlayVisible || overlayClosing || overlayOpening)" class="header">
420-
<slot
421-
name="overlay-header"
422-
:close="closeFullscreen"
423-
:run="handleRunClick"
424-
:run-loading="runButtonLoading"
425-
:rerun="handleRerunClick"
426-
:rerun-loading="rerunButtonLoading"
427-
:stop="handleStopClick"
428-
:stop-loading="stopButtonLoading"
429-
:runner-state="runnerState"
430-
:initial-loading="initialLoading"
431-
>
432-
<div class="header-left"></div>
433-
<div class="project-name">
434-
{{ project.name }}
435-
</div>
436-
<div class="header-right">
437-
<UIButton
438-
v-if="runnerState === 'initial'"
439-
v-radar="{ name: 'Run button', desc: 'Click to run the project in overlay' }"
440-
class="button"
441-
type="primary"
442-
icon="playHollow"
443-
:loading="runButtonLoading"
444-
@click="handleRunClick"
445-
>
446-
{{ $t({ en: 'Run', zh: '运行' }) }}
447-
</UIButton>
448-
<UIButton
449-
v-else-if="runnerState === 'running' && !stopButtonLoading"
450-
v-radar="{ name: 'Rerun button', desc: 'Click to rerun the project in overlay' }"
451-
class="button"
452-
icon="rotate"
453-
:loading="rerunButtonLoading"
454-
@click="handleRerunClick"
455-
>
456-
{{ $t({ en: 'Rerun', zh: '重新运行' }) }}
457-
</UIButton>
458-
<UIButton
459-
v-if="runnerState !== 'initial'"
460-
v-radar="{ name: 'Stop button', desc: 'Click to stop the project' }"
461-
class="button"
462-
type="boring"
463-
icon="end"
464-
:loading="stopButtonLoading"
465-
@click="handleStopClick"
466-
>
467-
{{ $t({ en: 'Stop', zh: '停止' }) }}
468-
</UIButton>
469-
<UITooltip>
470-
<template #trigger>
471-
<UIButton
472-
v-radar="{
473-
name: 'Exit full screen button',
474-
desc: 'Click to exit full screen for the running project'
475-
}"
476-
class="button"
477-
type="boring"
478-
icon="exitFullScreen"
479-
@click="closeFullscreen"
480-
></UIButton>
481-
</template>
482-
{{ $t({ en: 'Exit full screen', zh: '退出全屏' }) }}
483-
</UITooltip>
484-
</div>
485-
</slot>
415+
<div class="header-left"></div>
416+
<div class="project-name">
417+
{{ project.name }}
418+
</div>
419+
<div class="header-right">
420+
<UIButton
421+
v-if="runnerState === 'initial'"
422+
v-radar="{ name: 'Run button', desc: 'Click to run the project in overlay' }"
423+
class="button"
424+
type="primary"
425+
icon="playHollow"
426+
:loading="runButtonLoading"
427+
@click="handleRunClick"
428+
>
429+
{{ $t({ en: 'Run', zh: '运行' }) }}
430+
</UIButton>
431+
<UIButton
432+
v-else-if="runnerState === 'running' && !stopButtonLoading"
433+
v-radar="{ name: 'Rerun button', desc: 'Click to rerun the project in overlay' }"
434+
class="button"
435+
icon="rotate"
436+
:loading="rerunButtonLoading"
437+
@click="handleRerunClick"
438+
>
439+
{{ $t({ en: 'Rerun', zh: '重新运行' }) }}
440+
</UIButton>
441+
<UIButton
442+
v-if="runnerState !== 'initial'"
443+
v-radar="{ name: 'Stop button', desc: 'Click to stop the project' }"
444+
class="button"
445+
type="boring"
446+
icon="end"
447+
:loading="stopButtonLoading"
448+
@click="handleStopClick"
449+
>
450+
{{ $t({ en: 'Stop', zh: '停止' }) }}
451+
</UIButton>
452+
<UITooltip>
453+
<template #trigger>
454+
<UIButton
455+
v-radar="{
456+
name: 'Exit full screen button',
457+
desc: 'Click to exit full screen for the running project'
458+
}"
459+
class="button"
460+
type="boring"
461+
icon="exitFullScreen"
462+
@click="closeFullscreen"
463+
></UIButton>
464+
</template>
465+
{{ $t({ en: 'Exit full screen', zh: '退出全屏' }) }}
466+
</UITooltip>
467+
</div>
486468
</div>
487469
<div class="runner-area">
488470
<ProjectRunner
@@ -496,7 +478,6 @@ defineExpose({
496478
<div v-if="overlayActive && initialLoading && !overlayOpening" class="overlay-loading"></div>
497479
</div>
498480
</div>
499-
<slot name="inline-footer" />
500481
</div>
501482
</template>
502483

0 commit comments

Comments
 (0)