feat(spx-backend): Update image filtering configuration and beautification logic

Author: spf7000

spx-backend/cmd/spx-backend/post_image_beautify.yap

@@ -1,4 +1,4 @@
-// Beautify an uploaded SVG image using AI.
+// Beautify an uploaded PNG image using AI.
 //
 // Request:
 //   POST /image/beautify
@@ -23,18 +23,18 @@ if err != nil {
 	return
 }
 
-// Get SVG file from form
+// Get PNG file from form
 file, _, err := ctx.Request.FormFile("image")
 if err != nil {
-	replyWithCodeMsg(ctx, errorInvalidArgs, "SVG file is required")
+	replyWithCodeMsg(ctx, errorInvalidArgs, "PNG file is required")
 	return
 }
 defer file.Close()
 
-// Read SVG data
+// Read PNG data
 imageData, err := io.ReadAll(file)
 if err != nil {
-	replyWithCodeMsg(ctx, errorInvalidArgs, "Failed to read SVG data")
+	replyWithCodeMsg(ctx, errorInvalidArgs, "Failed to read PNG data")
 	return
 }
 

spx-backend/cmd/spx-backend/xgo_autogen.go

@@ -17,18 +17,31 @@ func TestImageFilterService_NewService(t *testing.T) {
 		t.Error("Service should have default config when nil is passed")
 	}
 
-	// Verify default values
-	defaultConfig := service.DefaultFilterConfig()
-	if defaultConfig.FilterWindowDays != 30 {
-		t.Errorf("Default FilterWindowDays = %d, want 30", defaultConfig.FilterWindowDays)
+	// Verify default values from service config
+	if service.config.DefaultWindowDays != 30 {
+		t.Errorf("Default DefaultWindowDays = %d, want 30", service.config.DefaultWindowDays)
+	}
+
+	if service.config.DefaultMaxFilterRatio != 0.8 {
+		t.Errorf("Default DefaultMaxFilterRatio = %.2f, want 0.8", service.config.DefaultMaxFilterRatio)
+	}
+
+	if !service.config.Enabled {
+		t.Error("Default config should be enabled")
 	}
 
+	// Verify DefaultFilterConfig method
+	defaultConfig := service.DefaultFilterConfig()
 	if defaultConfig.MaxFilterRatio != 0.8 {
 		t.Errorf("Default MaxFilterRatio = %.2f, want 0.8", defaultConfig.MaxFilterRatio)
 	}
 
 	if !defaultConfig.Enabled {
-		t.Error("Default config should be enabled")
+		t.Error("Default FilterConfig should be enabled")
+	}
+
+	if !defaultConfig.SessionEnabled {
+		t.Error("Default FilterConfig should have session filtering enabled")
 	}
 }
 
@@ -47,14 +60,36 @@ func TestImageFilterService_WithConfig(t *testing.T) {
 		t.Error("Service should use provided config")
 	}
 
-	defaultConfig := service.DefaultFilterConfig()
-	if defaultConfig.FilterWindowDays != 15 {
-		t.Errorf("Custom FilterWindowDays = %d, want 15", defaultConfig.FilterWindowDays)
+	// Test service config fields directly
+	if service.config.DefaultWindowDays != 15 {
+		t.Errorf("Custom DefaultWindowDays = %d, want 15", service.config.DefaultWindowDays)
+	}
+
+	if service.config.DefaultMaxFilterRatio != 0.6 {
+		t.Errorf("Custom DefaultMaxFilterRatio = %.2f, want 0.6", service.config.DefaultMaxFilterRatio)
+	}
+
+	if service.config.SearchExpansionRatio != 3.0 {
+		t.Errorf("Custom SearchExpansionRatio = %.1f, want 3.0", service.config.SearchExpansionRatio)
+	}
+
+	if service.config.EnableDegradation {
+		t.Error("EnableDegradation should be false")
+	}
+
+	if service.config.EnableMetrics {
+		t.Error("EnableMetrics should be false")
 	}
 
+	// Test DefaultFilterConfig method uses custom values
+	defaultConfig := service.DefaultFilterConfig()
 	if defaultConfig.MaxFilterRatio != 0.6 {
 		t.Errorf("Custom MaxFilterRatio = %.2f, want 0.6", defaultConfig.MaxFilterRatio)
 	}
+
+	if !defaultConfig.Enabled {
+		t.Error("FilterConfig should be enabled when config is enabled")
+	}
 }
 
 func TestDegradationStrategy_String(t *testing.T) {
@@ -86,36 +121,45 @@ func TestFilterConfig_Validation(t *testing.T) {
 		{
 			name: "Valid config",
 			config: FilterConfig{
-				FilterWindowDays: 30,
-				MaxFilterRatio:   0.8,
-				Enabled:          true,
+				MaxFilterRatio: 0.8,
+				SessionEnabled: true,
+				Enabled:        true,
+			},
+			expectError: false,
+		},
+		{
+			name: "Session disabled",
+			config: FilterConfig{
+				MaxFilterRatio: 0.8,
+				SessionEnabled: false,
+				Enabled:        true,
 			},
 			expectError: false,
 		},
 		{
-			name: "Zero window days",
+			name: "Zero filter ratio",
 			config: FilterConfig{
-				FilterWindowDays: 0,
-				MaxFilterRatio:   0.8,
-				Enabled:          true,
+				MaxFilterRatio: 0,
+				SessionEnabled: true,
+				Enabled:        true,
 			},
-			expectError: false, // Zero is valid, means no time filtering
+			expectError: false, // Zero is valid, means no filtering limit
 		},
 		{
-			name: "Invalid filter ratio too high",
+			name: "High filter ratio",
 			config: FilterConfig{
-				FilterWindowDays: 30,
-				MaxFilterRatio:   1.5,
-				Enabled:          true,
+				MaxFilterRatio: 1.0,
+				SessionEnabled: true,
+				Enabled:        true,
 			},
-			expectError: false, // Values > 1 are allowed in our implementation
+			expectError: false, // Values up to 1.0 are allowed
 		},
 		{
 			name: "Disabled config",
 			config: FilterConfig{
-				FilterWindowDays: 30,
-				MaxFilterRatio:   0.8,
-				Enabled:          false,
+				MaxFilterRatio: 0.8,
+				SessionEnabled: true,
+				Enabled:        false,
 			},
 			expectError: false,
 		},
@@ -126,12 +170,12 @@ func TestFilterConfig_Validation(t *testing.T) {
 			// For now, we just verify the config can be created without panicking
 			// In a real scenario, you'd add validation methods to FilterConfig
 			config := test.config
-			if config.FilterWindowDays < 0 {
-				t.Error("FilterWindowDays should not be negative")
-			}
 			if config.MaxFilterRatio < 0 {
 				t.Error("MaxFilterRatio should not be negative")
 			}
+			if config.MaxFilterRatio > 1.0 {
+				t.Error("MaxFilterRatio should not exceed 1.0")
+			}
 		})
 	}
 }
@@ -190,7 +234,7 @@ func TestFilterContext_Initialization(t *testing.T) {
 		QueryID:         "test-query",
 		Query:           "test query",
 		RequestedCount:  10,
-		Config:          &FilterConfig{FilterWindowDays: 30, MaxFilterRatio: 0.8, Enabled: true},
+		Config:          &FilterConfig{MaxFilterRatio: 0.8, SessionEnabled: true, Enabled: true},
 		DegradationUsed: DegradationNone,
 		Metrics:         &FilterMetrics{},
 	}
@@ -214,4 +258,17 @@ func TestFilterContext_Initialization(t *testing.T) {
 	if ctx.Metrics == nil {
 		t.Error("FilterContext Metrics should not be nil")
 	}
-}
+
+	// Verify config fields
+	if ctx.Config.MaxFilterRatio != 0.8 {
+		t.Errorf("FilterContext MaxFilterRatio = %.2f, want 0.8", ctx.Config.MaxFilterRatio)
+	}
+
+	if !ctx.Config.SessionEnabled {
+		t.Error("FilterContext SessionEnabled should be true")
+	}
+
+	if !ctx.Config.Enabled {
+		t.Error("FilterContext Enabled should be true")
+	}
+}

spx-backend/internal/controller/image_filter_service_simple_test.go

@@ -124,10 +124,6 @@ func TestImageRecommendationWithFiltering_ConfigDefaults(t *testing.T) {
 
 	defaultConfig := filterService.DefaultFilterConfig()
 
-	if defaultConfig.FilterWindowDays != 30 {
-		t.Errorf("Expected default FilterWindowDays=30, got %d", defaultConfig.FilterWindowDays)
-	}
-
 	if defaultConfig.MaxFilterRatio != 0.8 {
 		t.Errorf("Expected default MaxFilterRatio=0.8, got %.2f", defaultConfig.MaxFilterRatio)
 	}
@@ -136,6 +132,10 @@ func TestImageRecommendationWithFiltering_ConfigDefaults(t *testing.T) {
 		t.Error("Expected default filtering to be enabled")
 	}
 
+	if !defaultConfig.SessionEnabled {
+		t.Error("Expected default session filtering to be enabled")
+	}
+
 	// Test config getter methods
 	if filterService.config.GetDefaultWindowDays() != 30 {
 		t.Errorf("Expected GetDefaultWindowDays()=30, got %d", filterService.config.GetDefaultWindowDays())
@@ -340,4 +340,4 @@ func TestRecommendedImageResult_Structure(t *testing.T) {
 	if result.Source != "search" {
 		t.Errorf("Expected Source=search, got %s", result.Source)
 	}
-}
+}