Run os.path.getctime on full path instead of just filename

weiji14 · weiji14 · commit cf39fc7b13e5 · 2024-09-04T10:26:27.000+12:00
Signed-off-by: Wei Ji &lt;23487320+weiji14@users.noreply.github.com&gt;
diff --git a/fms_fsdp/utils/checkpointing_utils.py b/fms_fsdp/utils/checkpointing_utils.py
@@ -38,7 +38,7 @@ def get_oldest(targdir, qualifier=lambda x: True):
     if os.path.exists(targdir) and len(os.listdir(targdir)) > 0:
         oldest = min(
             [x for x in os.listdir(targdir) if qualifier(os.path.join(targdir, x))],
-            key=os.path.getctime,
+            key=lambda path: os.path.getctime(os.path.join(targdir, path)),
         )
         return os.path.join(targdir, oldest)
     return None

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ def get_oldest(targdir, qualifier=lambda x: True):`
`38`	`38`	`if os.path.exists(targdir) and len(os.listdir(targdir)) > 0:`
`39`	`39`	`oldest = min(`
`40`	`40`	`[x for x in os.listdir(targdir) if qualifier(os.path.join(targdir, x))],`
`41`		`- key=os.path.getctime,`
	`41`	`+ key=lambda path: os.path.getctime(os.path.join(targdir, path)),`
`42`	`42`	`)`
`43`	`43`	`return os.path.join(targdir, oldest)`
`44`	`44`	`return None`