snps_accel_rproc: Fix decoder size calculation for 40-bit address space #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dec_size computation to correctly set upper address bits for
40-bit address space support. Previous formula:
dec_size = ~(size - 1) >> 12;
ignored bits [39:32], causing incorrect address matching and routing
issues when high address bits differ from zero.
Fix by OR-ing with 0xFF00000 as per NPX memory map guidelines:
dec_size = (~(size - 1) >> 12) | 0xFF00000;
This change applies only to decoder size configuration.
Signed-off-by: Pavel Kozlov <pavel.kozlov@synopsys.com>
vadimbsnps
force-pushed
the
snps_accel-v5.15
branch
from
49d8d64 to
019d6d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dec_size computation to correctly set upper address bits for 40-bit address space support. Previous formula:
ignored bits [39:32], causing incorrect address matching and routing issues when high address bits differ from zero.
Fix by OR-ing with 0xFF00000 as per NPX memory map guidelines:
This change applies only to decoder size configuration.