Allow using non-absolute command names

Author: azimux

CHANGELOG.md

@@ -1,3 +1,7 @@
+## [1.1.1] - 2025-10-05
+
+- Allow using non-absolute command names
+
 ## [1.1.0] - 2025-08-22
 
 - Handle new Foobara 0.1.0 type declarations

Gemfile.lock

@@ -1,38 +1,38 @@
 PATH
   remote: .
   specs:
-    foobara-typescript-react-command-form-generator (1.1.0)
+    foobara-typescript-react-command-form-generator (1.1.1)
       foobara (>= 0.1.1, < 2.0.0)
       foobara-typescript-remote-command-generator (< 2.0.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.3)
-    bigdecimal (3.2.2)
+    bigdecimal (3.2.3)
     byebug (12.0.0)
     coderay (1.1.3)
     diff-lcs (1.6.2)
     docile (1.4.1)
     ffi (1.17.2-x86_64-linux-gnu)
-    foobara (0.1.7)
+    foobara (0.1.15)
       bigdecimal
       foobara-lru-cache (< 2.0.0)
       foobara-util (< 2.0.0)
       inheritable-thread-vars (< 2.0.0)
     foobara-files-generator (0.1.0)
       foobara (>= 0.1.1, < 2.0.0)
     foobara-lru-cache (1.0.0)
-    foobara-rubocop-rules (1.0.1)
+    foobara-rubocop-rules (1.0.3)
       rubocop
       rubocop-rspec
     foobara-spec-helpers (0.0.4)
       foobara-util
-    foobara-typescript-remote-command-generator (1.1.1)
-      foobara (>= 0.1.4, < 2.0.0)
+    foobara-typescript-remote-command-generator (1.1.4)
+      foobara (>= 0.1.14, < 2.0.0)
       foobara-files-generator (< 2.0.0)
-    foobara-util (1.0.2)
-    formatador (1.2.0)
+    foobara-util (1.0.3)
+    formatador (1.2.1)
       reline
     guard (2.19.1)
       formatador (>= 0.2.4)
@@ -52,14 +52,14 @@ GEM
       rspec (>= 2.99.0, < 4.0)
     inheritable-thread-vars (0.0.3)
     io-console (0.8.1)
-    json (2.13.2)
+    json (2.15.0)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     logger (1.7.0)
-    lumberjack (1.4.0)
+    lumberjack (1.4.2)
     method_source (1.1.0)
     nenv (0.3.0)
     notiffany (0.1.3)
@@ -70,7 +70,7 @@ GEM
     parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
-    prism (1.4.0)
+    prism (1.5.1)
     pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -83,7 +83,7 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.11.1)
       ffi (~> 1.0)
-    regexp_parser (2.11.2)
+    regexp_parser (2.11.3)
     reline (0.6.2)
       io-console (~> 0.5)
     rspec (3.13.1)
@@ -101,25 +101,25 @@ GEM
     rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.5)
-    rubocop (1.80.0)
+    rspec-support (3.13.6)
+    rubocop (1.81.1)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.46.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.46.0)
+    rubocop-ast (1.47.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
-    rubocop-rspec (3.6.0)
+    rubocop-rspec (3.7.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     ruby-progressbar (1.13.0)
@@ -131,9 +131,9 @@ GEM
     simplecov-html (0.13.2)
     simplecov_json_formatter (0.1.4)
     thor (1.4.0)
-    unicode-display_width (3.1.5)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
 
 PLATFORMS
   x86_64-linux

spec/write_typescript_react_command_form_to_disk_spec.rb

@@ -27,6 +27,17 @@
     ).to include("const [firstName, setFirstName] = useState<string | undefined>(undefined)")
   end
 
+  context "with a partial command name" do
+    let(:command_name) { "CommandWithDomainButNoOrg" }
+
+    it "is success" do
+      expect(outcome).to be_success
+      expect(
+        command.paths_to_source_code.keys
+      ).to include("forms/SomeDomainWithoutOrg/CommandWithDomainButNoOrgForm.tsx")
+    end
+  end
+
   context "without a manifest or url" do
     let(:raw_manifest) { nil }
 

src/generate_typescript_react_command_form.rb

@@ -43,18 +43,32 @@ def find_command_manifest
           self.command_manifest = Manifest::Command.new(manifest_data, [:command, command_name])
         rescue Manifest::InvalidPath
           valid_keys = manifest_data["command"].keys.sort
-          message = "Invalid command name: #{command_name}. Expected one of #{valid_keys.join(", ")}"
-          error = BadCommandNameError.new(
-            message:,
-            context: {
-              bad_name: command_name,
-              valid_names: valid_keys
-            },
-            path: [:command_name]
-          )
 
-          add_input_error(error)
-          halt!
+          suffix = command_name
+
+          unless suffix.start_with?("::")
+            suffix = "::#{suffix}"
+          end
+
+          matching_command_names = valid_keys.select { |key| key.end_with?(suffix) }
+
+          if matching_command_names.size == 1
+            best_command_name = matching_command_names.first
+            self.command_manifest = Manifest::Command.new(manifest_data, [:command, best_command_name])
+          else
+            message = "Invalid command name: #{command_name}. Expected one of #{valid_keys.join(", ")}"
+            error = BadCommandNameError.new(
+              message:,
+              context: {
+                bad_name: command_name,
+                valid_names: valid_keys
+              },
+              path: [:command_name]
+            )
+
+            add_input_error(error)
+            halt!
+          end
         end
 
         def add_command_manifest_to_set_of_elements_to_generate

version.rb

@@ -1,7 +1,7 @@
 module Foobara
   module Generators
     module TypescriptReactCommandFormGenerator
-      VERSION = "1.1.0".freeze
+      VERSION = "1.1.1".freeze
       MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
     end
   end