Skip to content

fix: plugin deactivation error #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alaminfirdows merged 4 commits into from
Apr 18, 2025
Merged

fix: plugin deactivation error #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cef8514
fix: plugin deactivation error
alaminfirdows Apr 18, 2025
3d70b15
fix: ensure proper unscheduling of cron event in deactivate method
alaminfirdows Apr 18, 2025
6b5546e
chore: fix phpcs
alaminfirdows Apr 18, 2025
95ed89a
fix: correct comment for plugin deactivation hook
alaminfirdows Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions flywp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,15 @@ public function activate() {
}

/**
* Plugin activation hook.
* Plugin deactivation hook.
*
* @return void
*/
public function deactivate() {
( new FlyWP\Api\UpdatesData() )->deactivate();
$timestamp = wp_next_scheduled( FlyWP\Api\UpdatesData::CRON_HOOK );
if ( $timestamp ) {
wp_unschedule_event( $timestamp, FlyWP\Api\UpdatesData::CRON_HOOK );
}
}

/**
Expand Down
16 changes: 2 additions & 14 deletions includes/Api/UpdatesData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@

namespace FlyWP\Api;

use WP_Error;

class UpdatesData {
private const CRON_HOOK = 'flywp_send_updates_data';
private const CRON_INTERVAL = 'twicedaily';
public const CRON_HOOK = 'flywp_send_updates_data';
public const CRON_INTERVAL = 'twicedaily';

/**
* UpdatesData constructor.
Expand Down Expand Up @@ -236,14 +234,4 @@ private function load_required_files(): void {
require_once ABSPATH . 'wp-admin/includes/update.php';
}
}

/**
* Deactivate the scheduler when the plugin is deactivated.
*/
public function deactivate(): void {
$timestamp = wp_next_scheduled( self::CRON_HOOK );
if ( $timestamp ) {
wp_unschedule_event( $timestamp, self::CRON_HOOK );
}
}
}