Skip to content

Commit 0895338

Browse files
committed
bytes is a reserved keyword
1 parent 35a3d2c commit 0895338

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

fluent/event.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33

44
class Event(object):
55
def __init__(self, label, data, **kwargs):
6-
if not isinstance(data, dict) :
7-
raise Exception("data must be dict")
6+
assert isinstance(data, dict), 'data must be a dict'
87
s = kwargs.get('sender', sender.get_global_sender())
98
timestamp = kwargs.get('time', int(time.time()))
109
s.emit_with_time(label, timestamp, data)

fluent/handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def _structuring(self, data, msg):
3636
elif isinstance(msg, str):
3737
try:
3838
self._add_dic(data, json.loads(str(msg)))
39-
except:
39+
except (ValueError, json.JSONDecodeError):
4040
pass
4141

4242
def _add_dic(self, data, dic):

fluent/sender.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def __init__(self,
3939

4040
try:
4141
self._reconnect()
42-
except:
42+
except Exception:
4343
# will be retried in emit()
4444
self._close()
4545

@@ -48,8 +48,8 @@ def emit(self, label, data):
4848
self.emit_with_time(label, cur_time, data)
4949

5050
def emit_with_time(self, label, timestamp, data):
51-
bytes = self._make_packet(label, timestamp, data)
52-
self._send(bytes)
51+
bytes_ = self._make_packet(label, timestamp, data)
52+
self._send(bytes_)
5353

5454
def _make_packet(self, label, timestamp, data):
5555
if label:
@@ -61,25 +61,25 @@ def _make_packet(self, label, timestamp, data):
6161
print(packet)
6262
return self.packer.pack(packet)
6363

64-
def _send(self, bytes):
64+
def _send(self, bytes_):
6565
self.lock.acquire()
6666
try:
67-
self._send_internal(bytes)
67+
self._send_internal(bytes_)
6868
finally:
6969
self.lock.release()
7070

71-
def _send_internal(self, bytes):
71+
def _send_internal(self, bytes_):
7272
# buffering
7373
if self.pendings:
74-
self.pendings += bytes
75-
bytes = self.pendings
74+
self.pendings += bytes_
75+
bytes_ = self.pendings
7676

7777
try:
7878
# reconnect if possible
7979
self._reconnect()
8080

8181
# send message
82-
self.socket.sendall(bytes)
82+
self.socket.sendall(bytes_)
8383

8484
# send finished
8585
self.pendings = None
@@ -91,7 +91,7 @@ def _send_internal(self, bytes):
9191
# TODO: add callback handler here
9292
self.pendings = None
9393
else:
94-
self.pendings = bytes
94+
self.pendings = bytes_
9595

9696
def _reconnect(self):
9797
if not self.socket:

0 commit comments

Comments
 (0)