Backport build fixes and -Werror in CI to 1.4.x#742
Merged
Conversation
See [1], [2]. GCC lets this slide but Clang does not and causes a Wattribute-warning. [1]: https://curl.se/libcurl/c/curl_easy_setopt.html [2]: https://github.com/curl/curl/blob/e8c1023b00b4b1491d0436f8bc95fe589ad659ed/include/curl/typecheck-gcc.h#L650-L655 (cherry picked from commit 20eca79)
gpointer * is void ** which does not match the expected type signature of the params in the typecheck macro [1], [2]. GCC lets this slide but Clang causes a -Wattribute-warning. [1]: https://github.com/curl/curl/blob/e8c1023b00b4b1491d0436f8bc95fe589ad659ed/include/curl/typecheck-gcc.h#L734 [2]: https://curl.se/libcurl/c/CURLOPT_WRITEFUNCTION.html (cherry picked from commit a8cb2d3)
OSTree has a typedef-redefinition in OstreeContentWriter, since it is allowed by C11 and earlier via GCC C11 extensions, ignore it for Clang builds (cherry picked from commit ae4ddc5)
Glibc 2.43 implements C23 const-preserving string-search functions [1] This fixes the build with Glibc 2.43 and GCC 15.1 (which defaults to C23). [1]: https://sourceware.org/glibc/wiki/Release/2.43#C23_Const-Preserving_Standard_Library_Macros_May_Break_Some_Packages (cherry picked from commit ebc4f5e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.