ci: Use ubuntu 26.04 container & Exercise -Werror in CI #738
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
bbhtt
changed the title
bbhtt
force-pushed
the
bbhtt/ci-container
branch
2 times, most recently
from
17ca12e to
582224b
Compare
Only for non-wrap path as upstream projects in wraps are unmaintained
It's only run in the release workflow which runs on tag creation, this reduces the difference and verifies dist tarball works on PRs when changes are being landed.
Needed for new dependencies like appstream, GitHub is yet to make actions-images available for 26.04 This separates the "install dependencies" step into two as we need git installed before checkout action runs (otherwise it fetches archive using REST API but unless it is a git repo, meson dist inside it will not work). The container does not have git, the Ubuntu actions-images used to have git installed.
|
Release pipeline works with the container, tested on my fork. https://github.com/bbhtt/flatpak-builder/actions/runs/26072219027/job/76655852239 |
|
Can we please not merge things without any review? Give it a few days and ping others if something seems stuck. |
|
We don't have a policy here requiring mandatory review or approvals by someone else. If you want to set up one I suggest we open an issue, gather consensus among recent committers and then we can document it and turn on the corresponding setting in GitHub. The changes seemed trivial to me. If there are any specific concerns regarding them, I'm open or reverting too if necessary. |
|
Sorry, but we have always required someone else to review PRs so if you want to change the process it seems like your responsibility to convince the others that we should change this. If the changes are trivial, reviewing them is as well. |
|
I don't see where that is documented? If I look at old PRs there are multiple examples where something has been merged without review from a second person. I can find a bunch from a cursory search, see #124, #311, #527, #563, #578 If it is indded the process we can gather consensus, formally document it as part of the project and make sure it is followed. |
2 participants
Needed for new dependencies like appstream, GitHub is yet to make actions-images available for 26.04