Merge pull request #4 from ysyneu/fix/channel-ids-array-filter

fix: send channel_ids array to /incident/list and /change/list

Author: ysyneu

changes.go

@@ -10,13 +10,16 @@ import (
 
 // ListChangesInput contains parameters for listing changes
 type ListChangesInput struct {
-	ChangeIDs []string // Direct lookup by change IDs
-	ChannelID int64    // Filter by collaboration space ID
-	StartTime int64    // Unix timestamp (seconds)
-	EndTime   int64    // Unix timestamp (seconds)
-	Type      string   // Filter by change type
-	Limit     int      // Max results (default 20)
-	Page      int      // Page number (default 1)
+	ChangeIDs  []string // Direct lookup by change IDs
+	ChannelIDs []int64  // Filter by collaboration space IDs
+	// Deprecated: use ChannelIDs. The backend /change/list endpoint expects
+	// channel_ids (array) — singular channel_id is silently ignored.
+	ChannelID int64
+	StartTime int64 // Unix timestamp (seconds)
+	EndTime   int64 // Unix timestamp (seconds)
+	Type      string
+	Limit     int
+	Page      int
 }
 
 // ListChangesOutput contains the result of listing changes
@@ -44,8 +47,8 @@ func (c *Client) ListChanges(ctx context.Context, input *ListChangesInput) (*Lis
 	if len(input.ChangeIDs) > 0 {
 		requestBody["change_ids"] = input.ChangeIDs
 	}
-	if input.ChannelID > 0 {
-		requestBody["channel_id"] = input.ChannelID
+	if channelIDs := mergeChannelIDs(input.ChannelIDs, input.ChannelID); len(channelIDs) > 0 {
+		requestBody["channel_ids"] = channelIDs
 	}
 	if input.StartTime > 0 {
 		requestBody["start_time"] = input.StartTime

helpers.go

@@ -20,6 +20,20 @@ func parseCommaSeparatedStrings(s string) []string {
 	return result
 }
 
+// mergeChannelIDs combines a primary slice with a deprecated singular ChannelID
+// field. The slice wins when set; otherwise a non-zero singular value is wrapped
+// into a one-element slice. Used to migrate callers from ChannelID to ChannelIDs
+// without breaking existing code.
+func mergeChannelIDs(channelIDs []int64, channelID int64) []int64 {
+	if len(channelIDs) > 0 {
+		return channelIDs
+	}
+	if channelID > 0 {
+		return []int64{channelID}
+	}
+	return nil
+}
+
 func parseCommaSeparatedInts(s string) []int {
 	if s == "" {
 		return nil

incidents.go

@@ -12,16 +12,21 @@ const defaultQueryLimit = 20
 
 // ListIncidentsInput contains parameters for listing incidents
 type ListIncidentsInput struct {
-	IncidentIDs   []string // Direct lookup by IDs (if set, other filters are ignored)
-	Progress      string   // Filter: Triggered, Processing, Closed (comma-separated for multiple)
-	Severity      string   // Filter: Info, Warning, Critical
-	ChannelID     int64    // Filter by collaboration space ID
-	StartTime     int64    // Unix timestamp (seconds), required if no IncidentIDs
-	EndTime       int64    // Unix timestamp (seconds), required if no IncidentIDs
-	Title         string   // Keyword search in incident title
-	Limit         int      // Max results (default 20, max 100)
-	Page          int      // Page number (default 1)
-	IncludeAlerts bool     // Whether to include alerts preview (default true)
+	IncidentIDs []string // Direct lookup by IDs (if set, other filters are ignored)
+	Progress    string   // Filter: Triggered, Processing, Closed (comma-separated for multiple)
+	Severity    string   // Filter: Info, Warning, Critical
+	ChannelIDs  []int64  // Filter by collaboration space IDs
+	// Deprecated: use ChannelIDs. If both are set, ChannelIDs wins; otherwise
+	// a non-zero ChannelID is wrapped into a single-element ChannelIDs slice.
+	// The backend /incident/list endpoint expects channel_ids (array) — singular
+	// channel_id is silently ignored.
+	ChannelID     int64
+	StartTime     int64 // Unix timestamp (seconds), required if no IncidentIDs
+	EndTime       int64 // Unix timestamp (seconds), required if no IncidentIDs
+	Title         string
+	Limit         int
+	Page          int
+	IncludeAlerts bool
 }
 
 // ListIncidentsOutput contains the result of listing incidents
@@ -50,7 +55,7 @@ func (c *Client) ListIncidents(ctx context.Context, input *ListIncidentsInput) (
 		if page <= 0 {
 			page = 1
 		}
-		rawIncidents, err = c.fetchIncidentsByFilters(ctx, input.Progress, input.Severity, input.ChannelID, input.StartTime, input.EndTime, input.Title, limit, page)
+		rawIncidents, err = c.fetchIncidentsByFilters(ctx, input.Progress, input.Severity, mergeChannelIDs(input.ChannelIDs, input.ChannelID), input.StartTime, input.EndTime, input.Title, limit, page)
 	}
 
 	if err != nil {
@@ -441,7 +446,7 @@ func (c *Client) fetchIncidentsByIDs(ctx context.Context, incidentIDs []string)
 }
 
 // fetchIncidentsByFilters fetches incidents by filters
-func (c *Client) fetchIncidentsByFilters(ctx context.Context, progress, severity string, channelID, startTime, endTime int64, title string, limit, page int) ([]RawIncident, error) {
+func (c *Client) fetchIncidentsByFilters(ctx context.Context, progress, severity string, channelIDs []int64, startTime, endTime int64, title string, limit, page int) ([]RawIncident, error) {
 	requestBody := map[string]any{
 		"p":          page,
 		"limit":      limit,
@@ -455,8 +460,8 @@ func (c *Client) fetchIncidentsByFilters(ctx context.Context, progress, severity
 	if severity != "" {
 		requestBody["incident_severity"] = severity
 	}
-	if channelID > 0 {
-		requestBody["channel_id"] = channelID
+	if len(channelIDs) > 0 {
+		requestBody["channel_ids"] = channelIDs
 	}
 	if title != "" {
 		requestBody["title"] = title