refactor: move incident adapters to sdk

Author: debidong

AGENTS.md

@@ -0,0 +1,8 @@
+# Agent Instructions
+
+## Flashduty SDK Boundary
+
+- Do not implement Flashduty public API endpoint clients directly in this CLI repository.
+- If a CLI command needs an endpoint that is missing from `github.com/flashcatcloud/flashduty-sdk`, add the typed adapter to `flashduty-sdk` first, with focused SDK tests.
+- The CLI should consume SDK methods and keep only command parsing, output formatting, and CLI-specific orchestration.
+- Existing raw HTTP adapters in the CLI are migration debt. Prefer removing them as SDK coverage catches up.

go.mod

@@ -3,17 +3,17 @@ module github.com/flashcatcloud/flashduty-cli
 go 1.25.1
 
 require (
-	github.com/flashcatcloud/flashduty-sdk v0.8.1-0.20260514094839-5405a3ab38b1
+	github.com/flashcatcloud/flashduty-sdk v0.8.1-0.20260520063928-ea6a81de4c95
 	github.com/mattn/go-runewidth v0.0.23
 	github.com/spf13/cobra v1.10.2
+	github.com/spf13/pflag v1.0.9
 	golang.org/x/term v0.42.0
 	gopkg.in/yaml.v3 v3.0.1
 )
 
 require (
 	github.com/clipperhouse/uax29/v2 v2.2.0 // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
-	github.com/spf13/pflag v1.0.9 // indirect
 	github.com/toon-format/toon-go v0.0.0-20251202084852-7ca0e27c4e8c // indirect
 	golang.org/x/sync v0.19.0 // indirect
 	golang.org/x/sys v0.43.0 // indirect

go.sum

@@ -1,8 +1,8 @@
 github.com/clipperhouse/uax29/v2 v2.2.0 h1:ChwIKnQN3kcZteTXMgb1wztSgaU+ZemkgWdohwgs8tY=
 github.com/clipperhouse/uax29/v2 v2.2.0/go.mod h1:EFJ2TJMRUaplDxHKj1qAEhCtQPW2tJSwu5BF98AuoVM=
 github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
-github.com/flashcatcloud/flashduty-sdk v0.8.1-0.20260514094839-5405a3ab38b1 h1:Q9FJkGSAQCXCjjnjS18QYMNpHT8O27oRj9kd13tUeiI=
-github.com/flashcatcloud/flashduty-sdk v0.8.1-0.20260514094839-5405a3ab38b1/go.mod h1:dG4eJfdZaj4jNBMwEexbfK/3PmcIMhNeJ88L/DcZzUY=
+github.com/flashcatcloud/flashduty-sdk v0.8.1-0.20260520063928-ea6a81de4c95 h1:b7O4LtOfecgmuq2Ipv6vkssHNFzqfUbo5utBuR8X4kI=
+github.com/flashcatcloud/flashduty-sdk v0.8.1-0.20260520063928-ea6a81de4c95/go.mod h1:dG4eJfdZaj4jNBMwEexbfK/3PmcIMhNeJ88L/DcZzUY=
 github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
 github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
 github.com/mattn/go-runewidth v0.0.23 h1:7ykA0T0jkPpzSvMS5i9uoNn2Xy3R383f9HDx3RybWcw=

internal/cli/command_test.go

@@ -9,6 +9,8 @@ import (
 	"testing"
 
 	flashduty "github.com/flashcatcloud/flashduty-sdk"
+	"github.com/spf13/cobra"
+	"github.com/spf13/pflag"
 )
 
 // mockClient provides default "not implemented" stubs for all flashdutyClient
@@ -71,38 +73,42 @@ func (m *mockClient) DisableIncidentMerge(context.Context, []string) error {
 	return fmt.Errorf("mockClient: DisableIncidentMerge not implemented")
 }
 
-func (m *mockClient) CommentIncidents(context.Context, *IncidentCommentInput) error {
+func (m *mockClient) CommentIncidents(context.Context, *flashduty.IncidentCommentInput) error {
 	return fmt.Errorf("mockClient: CommentIncidents not implemented")
 }
 
-func (m *mockClient) AddIncidentResponders(context.Context, *IncidentAddResponderInput) error {
+func (m *mockClient) AddIncidentResponders(context.Context, *flashduty.IncidentAddResponderInput) error {
 	return fmt.Errorf("mockClient: AddIncidentResponders not implemented")
 }
 
-func (m *mockClient) CreateIncidentWarRoom(context.Context, *IncidentWarRoomCreateInput) (*IncidentWarRoom, error) {
+func (m *mockClient) CreateIncidentWarRoom(context.Context, *flashduty.IncidentWarRoomCreateInput) (*flashduty.IncidentWarRoom, error) {
 	return nil, fmt.Errorf("mockClient: CreateIncidentWarRoom not implemented")
 }
 
-func (m *mockClient) ListIncidentWarRooms(context.Context, *IncidentWarRoomListInput) (*IncidentWarRoomListOutput, error) {
+func (m *mockClient) ListIncidentWarRooms(context.Context, *flashduty.IncidentWarRoomListInput) (*flashduty.IncidentWarRoomListOutput, error) {
 	return nil, fmt.Errorf("mockClient: ListIncidentWarRooms not implemented")
 }
 
-func (m *mockClient) GetIncidentWarRoom(context.Context, *IncidentWarRoomDetailInput) (*IncidentWarRoom, error) {
+func (m *mockClient) GetIncidentWarRoom(context.Context, *flashduty.IncidentWarRoomDetailInput) (*flashduty.IncidentWarRoom, error) {
 	return nil, fmt.Errorf("mockClient: GetIncidentWarRoom not implemented")
 }
 
-func (m *mockClient) DeleteIncidentWarRoom(context.Context, *IncidentWarRoomDeleteInput) error {
+func (m *mockClient) DeleteIncidentWarRoom(context.Context, *flashduty.IncidentWarRoomDeleteInput) error {
 	return fmt.Errorf("mockClient: DeleteIncidentWarRoom not implemented")
 }
 
-func (m *mockClient) AddIncidentWarRoomMembers(context.Context, *IncidentWarRoomAddMemberInput) error {
+func (m *mockClient) AddIncidentWarRoomMembers(context.Context, *flashduty.IncidentWarRoomAddMemberInput) error {
 	return fmt.Errorf("mockClient: AddIncidentWarRoomMembers not implemented")
 }
 
-func (m *mockClient) GetIncidentWarRoomDefaultObservers(context.Context, string) ([]IncidentWarRoomObserver, error) {
+func (m *mockClient) GetIncidentWarRoomDefaultObservers(context.Context, string) ([]flashduty.IncidentWarRoomObserver, error) {
 	return nil, fmt.Errorf("mockClient: GetIncidentWarRoomDefaultObservers not implemented")
 }
 
+func (m *mockClient) ListWarRoomEnabledDataSources(context.Context) (*flashduty.ListWarRoomEnabledDataSourcesOutput, error) {
+	return nil, fmt.Errorf("mockClient: ListWarRoomEnabledDataSources not implemented")
+}
+
 func (m *mockClient) ListChannels(context.Context, *flashduty.ListChannelsInput) (*flashduty.ListChannelsOutput, error) {
 	return nil, fmt.Errorf("mockClient: ListChannels not implemented")
 }
@@ -307,6 +313,8 @@ func saveAndResetGlobals(t *testing.T) {
 // and returns (stdout string, error). It also resets cobra flag state after
 // execution.
 func execCommand(args ...string) (string, error) {
+	resetCommandFlags(rootCmd)
+
 	buf := new(bytes.Buffer)
 	rootCmd.SetOut(buf)
 	rootCmd.SetErr(buf)
@@ -319,10 +327,35 @@ func execCommand(args ...string) (string, error) {
 	rootCmd.SetArgs(nil)
 	rootCmd.SetOut(nil)
 	rootCmd.SetErr(nil)
+	resetCommandFlags(rootCmd)
 
 	return buf.String(), err
 }
 
+func resetCommandFlags(cmd *cobra.Command) {
+	if cmd == nil {
+		return
+	}
+	resetFlagSet(cmd.Flags())
+	resetFlagSet(cmd.PersistentFlags())
+	for _, child := range cmd.Commands() {
+		resetCommandFlags(child)
+	}
+}
+
+func resetFlagSet(flags *pflag.FlagSet) {
+	if flags == nil {
+		return
+	}
+	flags.VisitAll(func(flag *pflag.Flag) {
+		switch flag.Value.Type() {
+		case "bool", "int", "int64", "string":
+			_ = flag.Value.Set(flag.DefValue)
+			flag.Changed = false
+		}
+	})
+}
+
 // ---------------------------------------------------------------------------
 // Test 191: incident get returns empty results
 // ---------------------------------------------------------------------------
@@ -665,8 +698,8 @@ type mockIncidentLifecycle struct {
 	wakeIDs         []string
 	removeIDs       []string
 	disableMergeIDs []string
-	commentInput    *IncidentCommentInput
-	responderInput  *IncidentAddResponderInput
+	commentInput    *flashduty.IncidentCommentInput
+	responderInput  *flashduty.IncidentAddResponderInput
 }
 
 func (m *mockIncidentLifecycle) UnackIncidents(_ context.Context, incidentIDs []string) error {
@@ -689,14 +722,14 @@ func (m *mockIncidentLifecycle) DisableIncidentMerge(_ context.Context, incident
 	return nil
 }
 
-func (m *mockIncidentLifecycle) CommentIncidents(_ context.Context, input *IncidentCommentInput) error {
+func (m *mockIncidentLifecycle) CommentIncidents(_ context.Context, input *flashduty.IncidentCommentInput) error {
 	copied := *input
 	copied.IncidentIDs = append([]string(nil), input.IncidentIDs...)
 	m.commentInput = &copied
 	return nil
 }
 
-func (m *mockIncidentLifecycle) AddIncidentResponders(_ context.Context, input *IncidentAddResponderInput) error {
+func (m *mockIncidentLifecycle) AddIncidentResponders(_ context.Context, input *flashduty.IncidentAddResponderInput) error {
 	copied := *input
 	copied.PersonIDs = append([]int64(nil), input.PersonIDs...)
 	if input.Notify != nil {
@@ -907,56 +940,61 @@ func TestCommandIncidentDisableMerge(t *testing.T) {
 type mockIncidentWarRoom struct {
 	mockClient
 
-	createInput           *IncidentWarRoomCreateInput
-	listInput             *IncidentWarRoomListInput
-	getInput              *IncidentWarRoomDetailInput
-	deleteInput           *IncidentWarRoomDeleteInput
-	addMemberInput        *IncidentWarRoomAddMemberInput
+	createInput           *flashduty.IncidentWarRoomCreateInput
+	listInput             *flashduty.IncidentWarRoomListInput
+	getInput              *flashduty.IncidentWarRoomDetailInput
+	deleteInput           *flashduty.IncidentWarRoomDeleteInput
+	addMemberInput        *flashduty.IncidentWarRoomAddMemberInput
 	defaultObserverIncID  string
-	defaultObserverOutput []IncidentWarRoomObserver
+	defaultObserverOutput []flashduty.IncidentWarRoomObserver
+	enabledDataSources    []flashduty.DataSourceIntegration
 }
 
-func (m *mockIncidentWarRoom) CreateIncidentWarRoom(_ context.Context, input *IncidentWarRoomCreateInput) (*IncidentWarRoom, error) {
+func (m *mockIncidentWarRoom) CreateIncidentWarRoom(_ context.Context, input *flashduty.IncidentWarRoomCreateInput) (*flashduty.IncidentWarRoom, error) {
 	copied := *input
 	copied.MemberIDs = append([]int64(nil), input.MemberIDs...)
 	m.createInput = &copied
-	return &IncidentWarRoom{ChatID: "chat-1", ChatName: "INC outage", ShareLink: "https://chat.example/1"}, nil
+	return &flashduty.IncidentWarRoom{ChatID: "chat-1", ChatName: "INC outage", ShareLink: "https://chat.example/1"}, nil
 }
 
-func (m *mockIncidentWarRoom) ListIncidentWarRooms(_ context.Context, input *IncidentWarRoomListInput) (*IncidentWarRoomListOutput, error) {
+func (m *mockIncidentWarRoom) ListIncidentWarRooms(_ context.Context, input *flashduty.IncidentWarRoomListInput) (*flashduty.IncidentWarRoomListOutput, error) {
 	copied := *input
 	m.listInput = &copied
-	return &IncidentWarRoomListOutput{
-		Items: []IncidentWarRoomItem{
+	return &flashduty.IncidentWarRoomListOutput{
+		Items: []flashduty.IncidentWarRoomItem{
 			{IntegrationID: 42, ChatID: "chat-1", IncidentID: "inc-1", Status: "enabled", PluginType: "feishu"},
 		},
 	}, nil
 }
 
-func (m *mockIncidentWarRoom) GetIncidentWarRoom(_ context.Context, input *IncidentWarRoomDetailInput) (*IncidentWarRoom, error) {
+func (m *mockIncidentWarRoom) GetIncidentWarRoom(_ context.Context, input *flashduty.IncidentWarRoomDetailInput) (*flashduty.IncidentWarRoom, error) {
 	copied := *input
 	m.getInput = &copied
-	return &IncidentWarRoom{ChatID: "chat-1", ChatName: "INC outage", ShareLink: "https://chat.example/1"}, nil
+	return &flashduty.IncidentWarRoom{ChatID: "chat-1", ChatName: "INC outage", ShareLink: "https://chat.example/1"}, nil
 }
 
-func (m *mockIncidentWarRoom) DeleteIncidentWarRoom(_ context.Context, input *IncidentWarRoomDeleteInput) error {
+func (m *mockIncidentWarRoom) DeleteIncidentWarRoom(_ context.Context, input *flashduty.IncidentWarRoomDeleteInput) error {
 	copied := *input
 	m.deleteInput = &copied
 	return nil
 }
 
-func (m *mockIncidentWarRoom) AddIncidentWarRoomMembers(_ context.Context, input *IncidentWarRoomAddMemberInput) error {
+func (m *mockIncidentWarRoom) AddIncidentWarRoomMembers(_ context.Context, input *flashduty.IncidentWarRoomAddMemberInput) error {
 	copied := *input
 	copied.MemberIDs = append([]int64(nil), input.MemberIDs...)
 	m.addMemberInput = &copied
 	return nil
 }
 
-func (m *mockIncidentWarRoom) GetIncidentWarRoomDefaultObservers(_ context.Context, incidentID string) ([]IncidentWarRoomObserver, error) {
+func (m *mockIncidentWarRoom) GetIncidentWarRoomDefaultObservers(_ context.Context, incidentID string) ([]flashduty.IncidentWarRoomObserver, error) {
 	m.defaultObserverIncID = incidentID
 	return m.defaultObserverOutput, nil
 }
 
+func (m *mockIncidentWarRoom) ListWarRoomEnabledDataSources(context.Context) (*flashduty.ListWarRoomEnabledDataSourcesOutput, error) {
+	return &flashduty.ListWarRoomEnabledDataSourcesOutput{Items: m.enabledDataSources}, nil
+}
+
 func TestCommandIncidentWarRoomCreateWithObservers(t *testing.T) {
 	saveAndResetGlobals(t)
 	mock := &mockIncidentWarRoom{}
@@ -980,10 +1018,48 @@ func TestCommandIncidentWarRoomCreateWithObservers(t *testing.T) {
 	}
 }
 
+func TestCommandIncidentWarRoomCreateAutoDiscoversIntegration(t *testing.T) {
+	saveAndResetGlobals(t)
+	mock := &mockIncidentWarRoom{
+		enabledDataSources: []flashduty.DataSourceIntegration{
+			{DataSourceID: 42, Name: "Feishu", PluginType: "feishu_app"},
+		},
+	}
+	newClientFn = func() (flashdutyClient, error) { return mock, nil }
+
+	out, err := execCommand("incident", "war-room", "create", "inc-1", "--member", "101")
+	if err != nil {
+		t.Fatalf("[incident-war-room-create-autodiscover] unexpected error: %v", err)
+	}
+	if mock.createInput == nil {
+		t.Fatal("[incident-war-room-create-autodiscover] expected CreateIncidentWarRoom to be called")
+	}
+	if mock.createInput.IntegrationID != 42 {
+		t.Fatalf("[incident-war-room-create-autodiscover] expected integration 42, got %#v", mock.createInput)
+	}
+	if !strings.Contains(out, "War room created: chat-1") {
+		t.Fatalf("[incident-war-room-create-autodiscover] unexpected output:\n%s", out)
+	}
+}
+
+func TestCommandIncidentWarRoomCreateRequiresEnabledIntegration(t *testing.T) {
+	saveAndResetGlobals(t)
+	mock := &mockIncidentWarRoom{}
+	newClientFn = func() (flashdutyClient, error) { return mock, nil }
+
+	_, err := execCommand("incident", "war-room", "create", "inc-1")
+	if err == nil || !strings.Contains(err.Error(), "no IM integration has war-room enabled") {
+		t.Fatalf("[incident-war-room-create-no-enabled-integration] expected enabled integration error, got %v", err)
+	}
+	if mock.createInput != nil {
+		t.Fatalf("[incident-war-room-create-no-enabled-integration] did not expect create call: %#v", mock.createInput)
+	}
+}
+
 func TestCommandIncidentWarRoomDefaultObservers(t *testing.T) {
 	saveAndResetGlobals(t)
 	mock := &mockIncidentWarRoom{
-		defaultObserverOutput: []IncidentWarRoomObserver{
+		defaultObserverOutput: []flashduty.IncidentWarRoomObserver{
 			{PersonID: 101, PersonName: "Alice", Email: "alice@example.com"},
 		},
 	}