Skip to content

Commit cd67947

Browse files
committed
fix: Refactor test classes to extend BaseTestCase for consistency
1 parent 7e86e0c commit cd67947

2 files changed

Lines changed: 15 additions & 13 deletions

File tree

tests/Hit/ActivateBatchTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,16 @@
22

33
namespace Flagship\Hit;
44

5+
use Flagship\BaseTestCase;
56
use Flagship\Config\DecisionApiConfig;
67
use Flagship\Enum\FlagshipConstant;
78
use Flagship\Flag\FSFlagMetadata;
8-
use PHPUnit\Framework\TestCase;
99

10-
class ActivateBatchTest extends TestCase
10+
class ActivateBatchTest extends BaseTestCase
1111
{
1212
public function testToApiKeys()
1313
{
14+
$this->mockRoundFunction();
1415

1516
$variationId = "varId";
1617
$variationGroupId = "varGrId";

tests/Hit/HitBatchTest.php

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,15 @@
22

33
namespace Flagship\Hit;
44

5+
use Flagship\BaseTestCase;
56
use Flagship\Config\DecisionApiConfig;
67
use Flagship\Enum\FlagshipConstant;
7-
use PHPUnit\Framework\TestCase;
88

9-
class HitBatchTest extends TestCase
9+
class HitBatchTest extends BaseTestCase
1010
{
1111
public function testToApiKeys()
1212
{
13+
$this->mockRoundFunction();
1314
$visitorId = "visitorId";
1415
$config = new DecisionApiConfig();
1516

@@ -20,19 +21,19 @@ public function testToApiKeys()
2021
$screen->setConfig($config)->setVisitorId($visitorId);
2122

2223
$hits = [
23-
$page,
24-
$screen,
25-
];
24+
$page,
25+
$screen,
26+
];
2627

2728
$batch = new HitBatch($config, [$page, $screen]);
2829

2930
$data = [
30-
FlagshipConstant::DS_API_ITEM => FlagshipConstant::SDK_APP,
31-
FlagshipConstant::CUSTOMER_ENV_ID_API_ITEM => $config->getEnvId(),
32-
FlagshipConstant::T_API_ITEM => "BATCH",
33-
FlagshipConstant::QT_API_ITEM => 0.0,
34-
FlagshipConstant::H_API_ITEM => [],
35-
];
31+
FlagshipConstant::DS_API_ITEM => FlagshipConstant::SDK_APP,
32+
FlagshipConstant::CUSTOMER_ENV_ID_API_ITEM => $config->getEnvId(),
33+
FlagshipConstant::T_API_ITEM => "BATCH",
34+
FlagshipConstant::QT_API_ITEM => 0.0,
35+
FlagshipConstant::H_API_ITEM => [],
36+
];
3637

3738
foreach ($hits as $hit) {
3839
$hitApiKey = $hit->toApiKeys();

0 commit comments

Comments
 (0)