Skip to content

Commit 062f9cd

Browse files
authored
Fs3 542 event value type (#7)
Fix Event hit value type: must be integer > 0
1 parent b91f55f commit 062f9cd

File tree

6 files changed

+8
-5
lines changed

6 files changed

+8
-5
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,4 @@ qa_db/
4747
flagship_database.db
4848
local_decision_file.json
4949
flagship/decision_file.json
50+
.run/

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ buildscript {
1414
if (flagship_version_name != null)
1515
rootProject.ext.flagship_version_name = flagship_version_name
1616
else
17-
rootProject.ext.flagship_version_name = "3.0.3"
17+
rootProject.ext.flagship_version_name = "3.0.4"
1818

1919
if (flagship_version_code != null)
2020
rootProject.ext.flagship_version_code = flagship_version_code

demo/src/main/java/com/abtasty/demo/DemoFlagship.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ public class DemoFlagship {
1414

1515
public static void main(String[] args) throws InterruptedException, ExecutionException {
1616

17+
18+
System.out.println("> " + System.getProperty("java.version"));
1719
CountDownLatch flagshipReadyLatch = new CountDownLatch(1);
1820
Flagship.start("_ENV_ID_", "_API_KEY_",
1921
new FlagshipConfig.DecisionApi()

demoqa/src/main/java/com/springboot/controller/HitController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public String sendHit(HttpServletRequest request, @RequestBody Map env) {
5959
if (env.get("el") != null && !env.get("el").toString().equals(""))
6060
event.withEventLabel(env.get("el").toString());
6161
if (env.get("ev") != null && !env.get("ev").toString().equals(""))
62-
event.withEventValue(Double.parseDouble(env.get("ev").toString()));
62+
event.withEventValue(Integer.parseInt(env.get("ev").toString()));
6363
if (env.get("re_wi") != null && !env.get("re_wi").toString().equals("") && env.get("re_he") != null && !env.get("re_he").toString().equals(""))
6464
event.withResolution(Integer.parseInt(env.get("re_wi").toString()), Integer.parseInt(env.get("re_he").toString()));
6565
if (env.get("ul") != null && !env.get("ul").toString().equals(""))

flagship/src/main/java/com/abtasty/flagship/hits/Event.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,12 @@ public Event withEventLabel(String label) {
4646
}
4747

4848
/**
49-
* Specifies a value for this event. must be non-negative. (optional)
49+
* Specifies a value for this event. must be non-negative integer > 0. (optional)
5050
*
5151
* @param value value of the event
5252
*/
53-
public Event withEventValue(Number value) {
54-
if (value != null)
53+
public Event withEventValue(int value) {
54+
if (value > 0)
5555
this.data.put(FlagshipConstants.HitKeyMap.EVENT_VALUE, value);
5656
return this;
5757
}

flagship_database.db

0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)