From 5e5799639a5764d7dafbfec127f85d1afb712c43 Mon Sep 17 00:00:00 2001 From: Kenneth Cheung Date: Mon, 26 Jan 2026 15:19:17 -0500 Subject: [PATCH 1/3] update ember diam to use 0.5 in spot --- src/behave/spot.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/behave/spot.cpp b/src/behave/spot.cpp index 07005c1..5d6f0ab 100644 --- a/src/behave/spot.cpp +++ b/src/behave/spot.cpp @@ -300,7 +300,7 @@ void Spot::calculateSpottingDistanceFromActiveCrown() { double windSpeed = spotInputs_.getWindSpeedAtTwentyFeet(SpeedUnits::KilometersPerHour);; double windHeight = 6.096; //20ft in meters - double emberDiamMm = 1.0; + double emberDiamMm = 0.5; CrownFirebrandProcessor *processor = new CrownFirebrandProcessor(treeHeight, firelineIntensity, From 22f987c545863ed6683ce2dc3eec37f1e4d51899 Mon Sep 17 00:00:00 2001 From: Kenneth Cheung Date: Mon, 26 Jan 2026 15:20:39 -0500 Subject: [PATCH 2/3] change default value of ember diam in crownFirebrandProcessor to 0.5 --- src/behave/CrownFirebrandProcessor.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/behave/CrownFirebrandProcessor.h b/src/behave/CrownFirebrandProcessor.h index 56330a7..5fdf2a0 100644 --- a/src/behave/CrownFirebrandProcessor.h +++ b/src/behave/CrownFirebrandProcessor.h @@ -16,7 +16,7 @@ class CrownFirebrandProcessor double fireInt=0., double windSpeed=0., double windHt=0., - double emberDiam=1., + double emberDiam=0.5, double ds=0.2); virtual ~CrownFirebrandProcessor(){} @@ -46,10 +46,10 @@ class CrownFirebrandProcessor // These are input property mutators void set( double canopyHt=0., double fireInt=0., double windSpeed=0., - double windHt=0., double emberDiam=1., double ds=0.2 ) ; + double windHt=0., double emberDiam=0.5, double ds=0.2 ) ; void setCanopyHeight( double canopyHt=0. ) ; void setDeltaStep( double deltaStep=0.2 ) ; - void setEmberDiameter( double emberDiam=1. ) ; + void setEmberDiameter( double emberDiam=0.5 ) ; void setFirelineIntensity( double fireInt=0. ) ; void setWindSpeed( double windSpeed=0. ) ; void setWindSpeedHeight( double windHt=0. ) ; From c97675902f7ffb2a3008d724c59683c70b21aab4 Mon Sep 17 00:00:00 2001 From: Kenneth Cheung Date: Tue, 27 Jan 2026 13:58:02 -0500 Subject: [PATCH 3/3] update tests --- src/testBehave/testBehave.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/testBehave/testBehave.cpp b/src/testBehave/testBehave.cpp index 2fa6c9a..97c939a 100644 --- a/src/testBehave/testBehave.cpp +++ b/src/testBehave/testBehave.cpp @@ -1424,7 +1424,7 @@ void testSpotModule(TestInfo& testInfo, BehaveRun& behaveRun) windSpeedAtTwentyFeet, windSpeedUnits, activeCrownFlameLength, flameHeightUnits); behaveRun.spot.calculateSpottingDistanceFromActiveCrown(); - expectedMountainSpottingDistance = 0.384247; + expectedMountainSpottingDistance = 0.400473; observedMountainSpottingDistance = roundToSixDecimalPlaces(behaveRun.spot.getMaxMountainousTerrainSpottingDistanceFromActiveCrown(spottingDistanceUnits)); reportTestResult(testInfo, testName, observedMountainSpottingDistance, expectedMountainSpottingDistance, error_tolerance);