Bug Description
In src/file_manipulator.py, the create_template() method contains a hardcoded Windows-only command:
os.system("taskkill /F /IM ollama.exe >nul 2>&1")
This silently fails on Linux and macOS — which is the target environment for Docker and CAL FIRE production deployments.
Impact
- Breaks
create_template() on any non-Windows system
- Docker containers run Linux — this command does nothing and logs no error
- Silent failure makes debugging extremely difficult in production
Steps to Reproduce
- Run FireForm on Linux or macOS
- Call the
/templates/create endpoint
- The taskkill command silently fails with no warning
Fix
Wrap the command in a platform check:
import platform
if platform.system() == "Windows":
os.system("taskkill /F /IM ollama.exe >nul 2>&1")
Additional
All print() statements in this file should also be replaced with
structured logging calls for production consistency.
Working on a PR for this fix.
Bug Description
In
src/file_manipulator.py, thecreate_template()method contains a hardcoded Windows-only command:This silently fails on Linux and macOS — which is the target environment for Docker and CAL FIRE production deployments.
Impact
create_template()on any non-Windows systemSteps to Reproduce
/templates/createendpointFix
Wrap the command in a platform check:
Additional
All
print()statements in this file should also be replaced withstructured
loggingcalls for production consistency.