From 61698099ad32246c273c17c8b5dda3dd28bce052 Mon Sep 17 00:00:00 2001 From: Pablo Brubeck Date: Fri, 24 Apr 2026 11:29:02 +0100 Subject: [PATCH 1/3] Fix f-string --- firedrake_rtree/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firedrake_rtree/__init__.py b/firedrake_rtree/__init__.py index 4866000..d94357b 100644 --- a/firedrake_rtree/__init__.py +++ b/firedrake_rtree/__init__.py @@ -18,4 +18,4 @@ def get_lib() -> str: def get_lib_filename() -> str: """Return the path to the rtree-capi shared object.""" - return os.path.join(get_lib(), f"firedrake_rtree{sysconfig.get_config_var("EXT_SUFFIX")}") + return os.path.join(get_lib(), f'firedrake_rtree{sysconfig.get_config_var("EXT_SUFFIX")}') From f1b7c1533195678074a97202c8742c7ca8c92282 Mon Sep 17 00:00:00 2001 From: Pablo Brubeck Date: Fri, 24 Apr 2026 11:30:42 +0100 Subject: [PATCH 2/3] better fix --- firedrake_rtree/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/firedrake_rtree/__init__.py b/firedrake_rtree/__init__.py index d94357b..aeb58f2 100644 --- a/firedrake_rtree/__init__.py +++ b/firedrake_rtree/__init__.py @@ -18,4 +18,5 @@ def get_lib() -> str: def get_lib_filename() -> str: """Return the path to the rtree-capi shared object.""" - return os.path.join(get_lib(), f'firedrake_rtree{sysconfig.get_config_var("EXT_SUFFIX")}') + sufix = sysconfig.get_config_var("EXT_SUFFIX") + return os.path.join(get_lib(), f"firedrake_rtree{sufix}") From 7a6f628ec90133c6e0dfe3d83ec2401238da1df5 Mon Sep 17 00:00:00 2001 From: Pablo Brubeck Date: Fri, 24 Apr 2026 12:06:42 +0100 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Leo Collins --- firedrake_rtree/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firedrake_rtree/__init__.py b/firedrake_rtree/__init__.py index aeb58f2..9f73d75 100644 --- a/firedrake_rtree/__init__.py +++ b/firedrake_rtree/__init__.py @@ -18,5 +18,5 @@ def get_lib() -> str: def get_lib_filename() -> str: """Return the path to the rtree-capi shared object.""" - sufix = sysconfig.get_config_var("EXT_SUFFIX") - return os.path.join(get_lib(), f"firedrake_rtree{sufix}") + suffix = sysconfig.get_config_var("EXT_SUFFIX") + return os.path.join(get_lib(), f"firedrake_rtree{suffix}")