this snippet
https://github.com/firedancer-io/firedancer/blob/282435aef345aa95d8d6590f2b74730e591bed5a/src/discoh/poh/fd_poh_tile.c#L1530C1-L1532C169
is a weird one. technically speaking, max(x, min(1, x)) is identically equal to x (see this).
- when
max_remaining_microblocks > 0, poh waits for pack to end block
- when
max_remaining_microblocks == 0, poh does not wait for pack end block (but it doesn't need to because we've received the max num of microblocks).
the question here then becomes: should we remove this line entirely or should we explicitly wait for pack even if no more microblocks can be received?
this snippet
https://github.com/firedancer-io/firedancer/blob/282435aef345aa95d8d6590f2b74730e591bed5a/src/discoh/poh/fd_poh_tile.c#L1530C1-L1532C169
is a weird one. technically speaking,
max(x, min(1, x))is identically equal tox(see this).max_remaining_microblocks > 0, poh waits for pack to end blockmax_remaining_microblocks == 0, poh does not wait for pack end block (but it doesn't need to because we've received the max num of microblocks).the question here then becomes: should we remove this line entirely or should we explicitly wait for pack even if no more microblocks can be received?