-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: asyncio not saving interrupt state #5568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I will add some tests soon. |
|
@dobrac I have improved your tests to iterate until pending ops queue is reproduced. |
Codecov Report❌ Patch coverage is Please upload reports for the commit 97d23a9 to get more accurate results.
Additional details and impacted files@@ Coverage Diff @@
## main #5568 +/- ##
==========================================
- Coverage 83.24% 83.23% -0.01%
==========================================
Files 277 277
Lines 29263 29268 +5
==========================================
+ Hits 24359 24362 +3
- Misses 4904 4906 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
During prepare_save we must unconditionally trigger an interrupt to ensure the guest gets notified after restore. The guest may have suppressed notifications, but after snapshot/restore it needs to be woken up regardless. Fixes firecracker-microvm#5554 Signed-off-by: Constantine Peresypkin <pconstantine@gmail.com>
|
Codecov idea of "coverage" seems incorrect here. Flagging a debug print is not the best use of coverage checks. So, ignored. |
During prepare_save we must unconditionally trigger an interrupt to ensure the guest gets notified after restore. The guest may have suppressed notifications, but after snapshot/restore it needs to be woken up regardless.
Fixes #5554
Changes
Fixes a bug where guest would hang indefinitely on interrupts after resume.
Reason
See above.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.