Add resource name and allow_missing param to source map registration

Author: tonybaroneee

npm-shrinkwrap.json

@@ -151,6 +151,7 @@
     "mime": "^2.5.2",
     "minimatch": "^3.0.4",
     "morgan": "^1.10.0",
+    "murmurhash-es": "^0.1.1",
     "node-fetch": "^2.6.7",
     "open": "^6.3.0",
     "ora": "^5.4.1",

package.json

@@ -195,13 +195,15 @@ describe("crashlytics:sourcemap:upload", () => {
     expect(clientPostStub).to.be.calledOnce;
     const args = clientPostStub.firstCall.args;
     expect(args[0]).to.match(
-      /\/projects\/test-project\/apps\/test-app\/locations\/global\/sourceMaps/,
+      /projects\/test-project\/apps\/test-app\/locations\/global\/sourceMaps/,
     );
     expect(args[1].sourceMap).to.deep.equal({
+      name: "projects/test-project/apps/test-app/locations/global/sourceMaps/2109677681",
       version: "a".repeat(40),
       obfuscatedFilePath: "src-test-fixtures-mapping-files-mock_mapping.js.map",
       fileUri: `gs://${BUCKET_NAME}/test-object`,
     });
+    expect(args[2].queryParams).to.deep.equal({ allowMissing: "true" });
   });
 
   it("should warn if registration fails", async () => {

src/commands/crashlytics-sourcemap-upload.spec.ts

@@ -13,6 +13,7 @@ import { Options } from "../options";
 import { archiveFile } from "../archiveFile";
 import { execSync } from "node:child_process";
 import { Client } from "../apiv2";
+import { murmurHashV3 } from "murmurhash-es";
 
 interface CommandOptions extends Options {
   app?: string;
@@ -22,6 +23,7 @@ interface CommandOptions extends Options {
 }
 
 interface SourceMap {
+  name: string;
   version: string;
   obfuscatedFilePath: string;
   fileUri: string;
@@ -187,7 +189,11 @@ async function uploadMap(
   try {
     const filePath = path.relative(options.projectRoot ?? process.cwd(), mappingFile);
     const tmpArchive = await archiveFile(filePath, { archivedFileName: "mapping.js.map" });
-    const gcsFile = `${options.app}-${appVersion}-${normalizeFileName(mappingFile)}.zip`;
+    const obfuscatedFilePath = normalizeFileName(filePath);
+    const gcsFile = `${options.app}-${appVersion}-${obfuscatedFilePath}.zip`;
+    const uid = murmurHashV3(`${appVersion}-${obfuscatedFilePath}`);
+    const parent = `projects/${projectId}/apps/${options.app}/locations/global/sourceMaps`;
+    const name = `${parent}/${uid}`;
 
     const { bucket, object } = await gcs.uploadObject(
       {
@@ -200,11 +206,11 @@ async function uploadMap(
     logger.debug(`Uploaded mapping file ${mappingFile} to ${fileUri}`);
 
     await registerSourceMap(
-      projectId,
-      options.app!,
+      parent,
       {
+        name,
         version: appVersion,
-        obfuscatedFilePath: normalizeFileName(mappingFile),
+        obfuscatedFilePath,
         fileUri,
       },
       options.telemetryServerUrl!,
@@ -222,8 +228,7 @@ function normalizeFileName(fileName: string): string {
 }
 
 async function registerSourceMap(
-  projectId: string,
-  appId: string,
+  parent: string,
   sourceMap: SourceMap,
   telemetryServerUrl: string,
 ): Promise<void> {
@@ -234,9 +239,13 @@ async function registerSourceMap(
   });
 
   try {
-    await client.post(`/projects/${projectId}/apps/${appId}/locations/global/sourceMaps`, {
-      sourceMap,
-    });
+    await client.post(
+      parent,
+      {
+        sourceMap,
+      },
+      { queryParams: { allowMissing: "true" } },
+    );
     logger.debug(
       `Registered source map ${sourceMap.obfuscatedFilePath} with Firebase Telemetry service`,
     );