test(ai): Add all general use models to integration tests #9413
Conversation
Adds all remaining general use models to the integration tests. This includes the `lite` models and the new `gemini-3-pro-preview`.
|
Summary of ChangesHello @dlarocque, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the integration test suite by incorporating all general-use AI models, including the new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request expands the integration test suite to include several new general-use models, which is a great addition for ensuring broader compatibility. The changes correctly update the model lists and adjust test expectations, such as token counts and timeouts, to accommodate the new models.
My review includes a couple of suggestions to improve code maintainability by reducing duplication and updating a stale comment. These are minor points in an otherwise solid update.
| let expectedImageTokens: number; | ||
| if (testConfig.model === 'gemini-3-pro-preview') { | ||
| expectedImageTokens = | ||
| testConfig.ai.backend.backendType === BackendType.GOOGLE_AI | ||
| ? 1089 | ||
| : 1120; | ||
| } else { | ||
| expectedImageTokens = 258; | ||
| } |
There was a problem hiding this comment.
This logic for determining expectedImageTokens is duplicated in a few places in this file (e.g., in the 'text, image, and audio input' test). To improve maintainability, consider extracting it into a shared helper function. This would centralize the logic and make future updates easier.
| if ( | ||
| testConfig.ai.backend.backendType === BackendType.GOOGLE_AI && | ||
| testConfig.model === 'gemini-2.0-flash' | ||
| ['gemini-2.0-flash-001', 'gemini-2.0-flash-lite-001'].includes( | ||
| testConfig.model | ||
| ) // Models that don't support URL Context | ||
| ) { |
There was a problem hiding this comment.
The logic in this if condition has been updated to be model-specific, rather than backend-specific. However, the comment on the preceding line (176) // URL Context is not supported in Google AI for gemini-2.0-flash is now outdated and potentially misleading. Please consider updating or removing it to align with the new implementation.
Size Report 1Affected ProductsNo changes between base commit (1e406a2) and merge commit (1f9db21).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (1e406a2) and merge commit (1f9db21).Test Logs |
2 participants
Adds all remaining general use models to the integration tests. This includes the
litemodels and the newgemini-3-pro-preview.