style(*): Automate Code Formatting (#90)

* style(*): add prettier automation

* fix(deps): fix issue where new typescript version was causing errors in the build

Something breaks in version 2.4.1 of typescript. We are pinning to 2.3.0 till those things can be
triaged and fixed

* WIP: remove tslint.json

Temporarily removing this file as we don't pass the checks

* refactor(style): refaactor to prefer single quotes over double quotes

* style(*): run prettier on codebase

Author: jshcrowthe

package.json

@@ -22,7 +22,8 @@
     "build:package": "gulp build && cd dist/package && npm install --production && npm shrinkwrap && npm pack && shx mv *.tgz ../",
     "test": "gulp build && gulp build:tests && gulp test && gulp test:integration",
     "dev": "gulp dev",
-    "commitmsg": "validate-commit-msg"
+    "commitmsg": "validate-commit-msg",
+    "precommit": "lint-staged"
   },
   "main": "index.js",
   "devDependencies": {
@@ -69,8 +70,10 @@
     "karma-mocha": "^1.3.0",
     "karma-spec-reporter": "^0.0.30",
     "karma-typescript": "^3.0.4",
+    "lint-staged": "^4.0.0",
     "merge2": "^1.0.3",
     "mkdirp": "^0.5.1",
+    "prettier": "^1.5.1",
     "require-dir": "^0.3.1",
     "rimraf": "^2.6.1",
     "shx": "^0.2.2",
@@ -98,5 +101,11 @@
     "cz-customizable": {
       "config": "./.cz-config.js"
     }
+  },
+  "lint-staged": {
+    "**/*.ts": [
+      "prettier --write --single-quote",
+      "git add"
+    ]
   }
 }

src/app.ts

@@ -14,12 +14,9 @@
 * limitations under the License.
 */
 // Import the createFirebaseNamespace function
-import { 
-  createFirebaseNamespace,
-  FirebaseNamespace
-} from './app/firebase_app';
+import { createFirebaseNamespace, FirebaseNamespace } from './app/firebase_app';
 
 // Export a single instance of firebase app
 const firebase: FirebaseNamespace = createFirebaseNamespace();
 
-export default firebase;
+export default firebase;

src/app/errors.ts

@@ -53,16 +53,16 @@
  *     }
  *   }
  */
-export type ErrorList<T> = {[code: string]: string};
+export type ErrorList<T> = { [code: string]: string };
 
 const ERROR_NAME = 'FirebaseError';
 
 export interface StringLike {
   toString: () => string;
 }
 
-let captureStackTrace: (obj: Object, fn?: Function) => void =
-  (Error as any).captureStackTrace;
+let captureStackTrace: (obj: Object, fn?: Function) => void = (Error as any)
+  .captureStackTrace;
 
 // Export for faking in tests
 export function patchCapture(captureFake?: any): any {
@@ -73,24 +73,23 @@ export function patchCapture(captureFake?: any): any {
 
 export interface FirebaseError {
   // Unique code for error - format is service/error-code-string
-  code: string,
+  code: string;
 
   // Developer-friendly error message.
-  message: string,
+  message: string;
 
   // Always 'FirebaseError'
-  name: string,
+  name: string;
 
   // Where available - stack backtrace in a string
-  stack: string,
+  stack: string;
 }
 
 export class FirebaseError implements FirebaseError {
   public stack: string;
   public name: string;
 
-  constructor(public code: string,
-              public message: string) {
+  constructor(public code: string, public message: string) {
     let stack: string;
     // We want the stack value, if implemented by Error
     if (captureStackTrace) {
@@ -116,31 +115,32 @@ FirebaseError.prototype.constructor = FirebaseError;
 
 export class ErrorFactory<T extends string> {
   // Matches {$name}, by default.
-  public pattern = /\{\$([^}]+)}/g
+  public pattern = /\{\$([^}]+)}/g;
 
-  constructor(private service: string,
-              private serviceName: string,
-              private errors: ErrorList<T>) {
+  constructor(
+    private service: string,
+    private serviceName: string,
+    private errors: ErrorList<T>
+  ) {
     // empty
   }
 
-  create(code: T, data?: {[prop: string]: StringLike}): FirebaseError {
+  create(code: T, data?: { [prop: string]: StringLike }): FirebaseError {
     if (data === undefined) {
       data = {};
     }
 
-    let template = this.errors[(code as string)];
+    let template = this.errors[code as string];
 
     let fullCode = this.service + '/' + code;
     let message: string;
 
     if (template === undefined) {
-      message = "Error";
+      message = 'Error';
     } else {
       message = template.replace(this.pattern, (match, key) => {
         let value = data![key];
-        return value !== undefined ? value.toString()
-          : '<' + key + '?>';
+        return value !== undefined ? value.toString() : '<' + key + '?>';
       });
     }
 
@@ -159,4 +159,4 @@ export class ErrorFactory<T extends string> {
 
     return err;
   }
-}
+}