Skip to content

Commit 30e6e10

Browse files
Addressing gemini review comments
1 parent 8f1dcda commit 30e6e10

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

spec/v2/providers/pubsub.spec.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,14 @@ describe("onMessagePublished", () => {
202202
expect(receivedEvent.type).to.equal("google.cloud.pubsub.topic.v1.messagePublished");
203203
expect(receivedEvent.source).to.equal("//pubsub.googleapis.com/projects/aProject/topics/topic");
204204
expect(receivedEvent.data.message.json).to.deep.equal({ hello: "world" });
205+
expect(receivedEvent.context).to.exist;
206+
expect(receivedEvent.context.eventId).to.equal("uuid");
207+
expect(receivedEvent.context.timestamp).to.equal(publishTime);
208+
expect(receivedEvent.context.eventType).to.equal("google.cloud.pubsub.topic.v1.messagePublished");
209+
expect(receivedEvent.context.resource).to.deep.equal({
210+
service: "pubsub.googleapis.com",
211+
name: "projects/aProject/topics/topic",
212+
});
205213
});
206214

207215
// These tests pass if the transpiler works
@@ -228,6 +236,7 @@ describe("onMessagePublished", () => {
228236
);
229237
});
230238

239+
//Test case to ensure Idempotency. makes things dont break if there is already context present
231240
it("should not modify a CloudEvent that already has a context", async () => {
232241
const publishTime = new Date().toISOString();
233242
const message = {
@@ -266,6 +275,8 @@ describe("onMessagePublished", () => {
266275
expect(receivedEvent.context).to.deep.equal(existingContext);
267276
});
268277

278+
279+
//Test case to ensure GCLOUD_PROJECT is used as fallback for resource name
269280
it("should use GCLOUD_PROJECT as fallback for resource name", async () => {
270281
const publishTime = new Date().toISOString();
271282
const message = {
@@ -324,6 +335,6 @@ describe("onMessagePublished", () => {
324335

325336
await func(event);
326337

327-
expect(receivedEvent.context.resource.name).to.equal("project/unknown-project/topics/topic");
338+
expect(receivedEvent.context.resource.name).to.equal("projects/unknown-project/topics/topic");
328339
});
329340
});

src/v2/providers/pubsub.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ function getResourceName(event: CloudEvent<MessagePublishedData<any>>, topic: st
413413
const topicName = match?.[2] ?? topic;
414414

415415
if (!project) {
416-
return `project/unknown-project/topics/${topicName}`;
416+
return `projects/unknown-project/topics/${topicName}`;
417417
}
418418

419419
return `projects/${project}/topics/${topicName}`;

0 commit comments

Comments
 (0)