-
Notifications
You must be signed in to change notification settings - Fork 270
feat(firestore): Added Firestore Multi Database Support #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jonathanedey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Firestore client by introducing support for multiple named databases. It provides a new API method, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for multiple Cloud Firestore databases by adding a new FirestoreWithDatabase function. The implementation is accompanied by comprehensive unit and integration tests. My feedback focuses on improving code maintainability by addressing code duplication and enhancing the robustness of the integration tests to ensure proper resource cleanup.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for multiple named databases in Cloud Firestore by adding a FirestoreWithDatabase method. The implementation maintains backward compatibility by having the existing Firestore method call the new one with the default database ID. The changes are well-tested with new unit and integration tests. My review includes a couple of suggestions for the new integration tests to improve maintainability and adhere to Go's testing best practices.
RELEASE NOTE: Added support for multiple Cloud Firestore named databases.