Skip to content

Commit b741ba4

Browse files
committed
performance report: no error on portfolios without reports
Do not generate an error on bundles that have a portfolio without cashflow in this time period. Fixes #179
1 parent 31c9a17 commit b741ba4

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

poms/reports/performance_report.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1010,7 +1010,6 @@ def build_modified_dietz(self, date_from, date_to): # noqa: PLR0915
10101010

10111011
if date_to > date_from:
10121012
no_first_date = []
1013-
no_register_records = []
10141013
for register in portfolio_registers:
10151014
portfolio = register.portfolio
10161015
first_transaction_date = portfolio.first_transaction_date
@@ -1029,10 +1028,6 @@ def build_modified_dietz(self, date_from, date_to): # noqa: PLR0915
10291028
],
10301029
).order_by("transaction_date")
10311030

1032-
if not portfolio_records:
1033-
no_register_records.append(portfolio.user_code)
1034-
continue
1035-
10361031
portfolio_records = portfolio_records.filter(
10371032
transaction_date__gte=max(
10381033
date_from, first_transaction_date
@@ -1125,15 +1120,6 @@ def build_modified_dietz(self, date_from, date_to): # noqa: PLR0915
11251120
# ),
11261121
# )
11271122

1128-
if no_register_records:
1129-
raise FinmarsBaseException(
1130-
error_key="no_portfolio_register_records",
1131-
message=(
1132-
f"No portfolio register records found for the following portfolios "
1133-
f"for the specified period: {', '.join(no_register_records)}"
1134-
),
1135-
)
1136-
11371123
try:
11381124
cf_adjusted_total_nav = total_nav + grand_cash_flow
11391125
wcf_adjusted_total_nav = total_nav + grand_cash_flow_weighted

0 commit comments

Comments
 (0)