fix: sync properties from any instance, not just leader#18
Merged
Conversation
Remove module-level isLeaderInstance variable and its check from OPC guards. The leader check should only gate the periodic update timer, not property syncing between instances.
derek-miller
approved these changes
Mar 26, 2026
svc-finitelabs Bot
added a commit
that referenced
this pull request
Mar 31, 2026
Remove module-level isLeaderInstance variable and its check from OPC guards. The leader check should only gate the periodic update timer, not property syncing between instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DRV-22 PR was merged without the leader-instance fix. This applies the same pattern as the other drivers: remove module-level
isLeaderInstance, drop it from OPC guards, scope it locally in the update timer.