src/slack does not honour Makefile.common

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Download slack-0.15.2.tar.gz
2. Edit Makefile.common to suit environment. Edit exec_prefix = /usr/local 
rather than /usr
3. make; make install
4. slack fails to run

What is the expected output? What do you see instead?

# slack
Can't locate Slack.pm in @INC (@INC contains: /usr/lib/slack 
/usr/libdata/perl5/i386-openbsd/5.10.1 
/usr/local/libdata/perl5/i386-openbsd/5.10.1 /usr/libdata/perl5 
/usr/local/libdata/perl5 /usr/local/libdata/perl5/site_perl/i386-openbsd 
/usr/libdata/perl5/site_perl/i386-openbsd /usr/local/libdata/perl5/site_perl 
/usr/libdata/perl5/site_perl .) at /usr/local/sbin/slack line 25.
BEGIN failed--compilation aborted at /usr/local/sbin/slack line 25.

What version of the product are you using? On what operating system?

0.15.2 on OpenBSD

Please provide any additional information below.

The source file src/slack has the following hardcoded rather than using the 
Makefile.common definition: 

use constant LIBEXEC_DIR => '/usr/lib/slack';
use constant LIB_DIR => '/usr/lib/slack';

The edits I made to Makefile.common:

exec_prefix     = /usr/local
libexecdir      = ${exec_prefix}/libexec
slack_localstatedir     = ${localstatedir}/spool/slack

The six files in /usr/local/libexec/slack also have LIB_DIR hardcoded. Also it 
might be nice to have /etc/slack.conf install with STAGE= and BACKUP_DIR= set 
to make what is defined in Makefile.common.

Original issue reported on code.google.com by dan.walr...@gmail.com on 27 Jan 2011 at 6:43