Skip to content

Fix: Increased minimum window size to prevent crash when resizing wit… #17893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
workbysaran wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −1
Open

Fix: Increased minimum window size to prevent crash when resizing wit… #17893

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d20c018
Fix: Increased minimum window size to prevent crash when resizing wit…
workbysaran Nov 21, 2025
3b4485a
Fix: Fixed crash when resizing window with split panes active. Revert…
workbysaran Dec 5, 2025
5305c7b
Code Quality: Removed whitespace
workbysaran Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Files.App/Views/ShellPanesPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public sealed partial class ShellPanesPage : Page, IShellPanesPage, ITabBarItemC
// Fields

private bool _wasRightPaneVisible;
private NavigationParams? _savedNavParamsRight;

// Properties

Expand Down Expand Up @@ -105,15 +106,25 @@ public bool WindowIsCompact
// Close pane
_wasRightPaneVisible = GetPaneCount() >= 2;

if (GetPaneCount() >= 2)
if (_wasRightPaneVisible)
{
var currentPath = GetPane(1)?.TabBarItemParameter?.NavigationParameter as string ?? "Home";
_savedNavParamsRight = new NavigationParams { NavPath = currentPath };
RemovePane(1);
}
}
else if (_wasRightPaneVisible)
{
// Add back pane
if (GetPaneCount() == 1)
AddPane();

if (_savedNavParamsRight is not null)
{
NavParamsRight = _savedNavParamsRight;
_savedNavParamsRight = null;
}

_wasRightPaneVisible = false;
}

Expand Down
Loading