Bypass cohort selection for staff

[nemvince]

[coderabbitai]

Coding Plan

Summary

• Leverage the existing RBAC system by checking for a "teacher" role rather than implementing new teacher-user linking infrastructure
• Enrich the session once on the backend, allowing all frontend components to access teacher status consistently
• Modify the banner's hide condition to include teacher status, ensuring teachers aren't nagged about cohort selection
• Provide teachers a streamlined wizard experience with a contextual message instead of requiring them to interact with an irrelevant cohort picker

Design Choices

Design Choice 1: How should teacher identity be determined?

Options Considered:

1. Check teacher.userId matches the logged-in user's ID (requires future work to populate this field)
2. Check if the user has a role named "teacher" in their roles array (works immediately with existing role management UI)
3. Combine both checks with OR logic (most flexible)

Chosen Option: 2

Rationale: Use role-based check (user.roles.includes('teacher')). This requires no schema changes or new endpoints, and admins can immediately assign the "teacher" role to users via the existing roles management interface. The teacher-table-based check can be added later as an enhancement when teacher-user linking is implemented.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Backend Session Enrichment

Add an isTeacher boolean to the session user object so the frontend can conditionally render UI based on teacher status.

Add isTeacher to Session User Object

Enrich the session with teacher identity information derived from the user's roles array.

• Modify apps/chronos/src/utils/authentication.ts in the customSession callback to compute and include isTeacher: user.roles.includes('teacher') in the returned user object
• This requires no additional database query since user.roles is already available on the user object via additionalFields
• The type will automatically propagate to Iris via the existing inferAdditionalFields<AuthType>() setup in the frontend auth client

🤖 Prompt for AI agents

Add an `isTeacher` boolean field to the session user object in the backend
authentication utility.

- In `apps/chronos/src/utils/authentication.ts`, locate the `customSession`
callback
- Compute and include `isTeacher: user.roles.includes('teacher')` in the
returned user object
- No additional database query is needed since `user.roles` is already available
via `additionalFields`
- The type will automatically propagate to Iris via the existing
`inferAdditionalFields<AuthType>()` setup in the frontend auth client

Phase 2: Frontend Teacher Bypass Logic

Update the banner and welcome wizard to recognize teachers and provide them an appropriate experience that doesn't require cohort selection.

Task 1: Update Cohort Reselection Banner

Modify the banner visibility logic so teachers without a cohortId are not prompted to select one.

• Update apps/iris/src/components/cohort-reselection-banner.tsx to add isTeacher to the early-return condition
• The banner should return null (hide) when the user is a teacher, in addition to the existing conditions (no session, loading, cohortId present, or on welcome page)
• Extract isTeacher from data?.user?.isTeacher alongside the existing cohortId extraction

Task 2: Modify Welcome Wizard for Teachers

Adapt the cohort selection step to provide teachers with an appropriate experience instead of the cohort picker.

• Update apps/iris/src/routes/auth/welcome.tsx to detect teacher status from the session user object
• Modify the CohortSelectorStep rendering logic to show a teacher-specific message (e.g., "As a teacher, you don't need to select a cohort") instead of the cohort dropdown when user.isTeacher is true
• The step should still allow the user to continue to the completion step without requiring any selection
• Ensure the "Continue" button in the teacher variant advances to the next step without attempting to save a cohortId

Task 3: Add Translation Keys for Teacher UI

Add internationalization support for the teacher-specific messaging in the wizard.

• Add English translation keys in apps/iris/public/locales/en/translation.json for the teacher bypass message in the welcome wizard
• Add Hungarian translation keys in apps/iris/public/locales/hu/translation.json for the same content
• Follow the existing translation key naming patterns used in the welcome wizard section

🤖 Prompt for AI agents

Update frontend components to recognize teacher status and bypass cohort-related
UI accordingly. This phase covers three files: the cohort reselection banner,
the welcome wizard, and translation files.

**Task 1 – Cohort Reselection Banner
(`apps/iris/src/components/cohort-reselection-banner.tsx`)**
- Extract `isTeacher` from `data?.user?.isTeacher` alongside the existing
`cohortId` extraction
- Add `isTeacher` to the early-return condition so the banner returns `null`
(hides) when the user is a teacher, in addition to the existing hide conditions
(no session, loading, `cohortId` present, or on welcome page)

**Task 2 – Welcome Wizard (`apps/iris/src/routes/auth/welcome.tsx`)**
- Detect teacher status from the session user object (`user.isTeacher`)
- Modify the `CohortSelectorStep` rendering logic: when `user.isTeacher` is
true, show a teacher-specific message (e.g., "As a teacher, you don't need to
select a cohort") instead of the cohort dropdown
- The step must still allow the user to continue to the completion step without
requiring any selection
- Ensure the "Continue" button in the teacher variant advances to the next step
without attempting to save a `cohortId`

**Task 3 – Translation Files**
- Add English translation keys in `apps/iris/public/locales/en/translation.json`
for the teacher bypass message in the welcome wizard
- Add Hungarian translation keys in
`apps/iris/public/locales/hu/translation.json` for the same content
- Follow the existing translation key naming patterns used in the welcome wizard
section

Research

This is a monorepo with two apps: Chronos (Bun/Hono backend) and Iris (React/Vite frontend). User authentication uses better-auth with a customSession plugin that enriches sessions with displayName and permissions. The welcome wizard at /auth/welcome has 4 fixed steps including cohort selection, and a CohortReselectionBanner component globally prompts users who lack a cohortId. Teacher identity exists as a separate teacher table with an optional userId FK to link to user accounts, but this column is currently never populated during timetable import. The RBAC system uses named roles with permission arrays.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

Add an `isTeacher` boolean field to the session user object in the backend
authentication utility.

- In `apps/chronos/src/utils/authentication.ts`, locate the `customSession`
callback
- Compute and include `isTeacher: user.roles.includes('teacher')` in the
returned user object
- No additional database query is needed since `user.roles` is already available
via `additionalFields`
- The type will automatically propagate to Iris via the existing
`inferAdditionalFields<AuthType>()` setup in the frontend auth client
===============================================================================

Task: 2

Update frontend components to recognize teacher status and bypass cohort-related
UI accordingly. This phase covers three files: the cohort reselection banner,
the welcome wizard, and translation files.

**Task 1 – Cohort Reselection Banner
(`apps/iris/src/components/cohort-reselection-banner.tsx`)**
- Extract `isTeacher` from `data?.user?.isTeacher` alongside the existing
`cohortId` extraction
- Add `isTeacher` to the early-return condition so the banner returns `null`
(hides) when the user is a teacher, in addition to the existing hide conditions
(no session, loading, `cohortId` present, or on welcome page)

**Task 2 – Welcome Wizard (`apps/iris/src/routes/auth/welcome.tsx`)**
- Detect teacher status from the session user object (`user.isTeacher`)
- Modify the `CohortSelectorStep` rendering logic: when `user.isTeacher` is
true, show a teacher-specific message (e.g., "As a teacher, you don't need to
select a cohort") instead of the cohort dropdown
- The step must still allow the user to continue to the completion step without
requiring any selection
- Ensure the "Continue" button in the teacher variant advances to the next step
without attempting to save a `cohortId`

**Task 3 – Translation Files**
- Add English translation keys in `apps/iris/public/locales/en/translation.json`
for the teacher bypass message in the welcome wizard
- Add Hungarian translation keys in
`apps/iris/public/locales/hu/translation.json` for the same content
- Follow the existing translation key naming patterns used in the welcome wizard
section

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!