run on any domain

[tcurdt]

IIUC the the list of supported domains is fix in the manifest - but I can also set the permission to "allow on click".

There are blogs and sites that seem to use medium on their own domain. Adding all to the manifest seems a little crazy.

Would it be possible to show the button for those domains that are not in the manifest but got explicit permissions?

[fferrin]

Hi @tcurdt. Thanks for reaching out.

I’ve been thinking about hardcoding the domains as they are now in the manifest. One issue with not using this list is that the “Read for free” button would show up on every page. We can prevent this with code, but we’d still need to hardcode the list somewhere. On the bright side, it also serves as documentation for all supported Medium domains.

To accommodate your suggestion, I think we could:

• Allow the extension to run on every domain
• Move the list from the manifest into the JS code
• Add the contextMenus permission to let users right-click on an unsupported domain and add it to a list in their localStorage
  • If the domain is in the hardcoded list, the button is shown (as it works now)
  • If it’s not, the user can right-click and add it to their local list; the button will then appear for that domain

Unfortunately, I don’t have enough time to work on this right now, but feel free to send a PR (with these changes or with domains you'd like added to the manifest) and I’ll review it.

[tcurdt]

It should actually be less code - not more. Let me explain...

How I would love to use it:

• "allow for all domains"
• I set the extension to "allow on click"

So the button would NOT show on all pages.
I would need to click the button in my browser bar to enable the extension for the page.

That should actually mean: no lists to maintain and no extra code to add.

In theory this mean it wouldn't even need an extra button at all.
Enabling the extension for the page could be that button.
So it would mean removing code :)

Just not sure how most users use the extension and if that is an OK change.
But this would follow good privacy practises.

[fferrin]

Hey @tcurdt, I had this pending issue in mind but forgot to reply. Sorry about that.

One possible issue I see with this is that the button could be hidden in the list of extensions if the user doesn’t manually pin it to the top bar (even then, I have many pinned and sometimes forget which is which). Since I haven’t received any complaints about the UX (quite the opposite actually, something I really appreciate), the allowed list is still manageable (at least for now), and people have started requesting and even contributing to this project, I think it will stay as it is for now.

I’ll keep this open and handy in case more users start requesting it. In the meantime, although not the best solution, I’m happy to keep adding domains upon user request.

[tcurdt]

I have one article on rizqimulki.com I was hoping to read.
Since I am using the head branch I assume I could also just add it to my local clone of the plugin? Should that work with the provider?