Skip to content

Commit e5ebfec

Browse files
committed
Switch to using core serialization headers instead of mercury specific ones.
1 parent 2ef5400 commit e5ebfec

12 files changed

Lines changed: 31 additions & 87 deletions

File tree

src/sst/elements/iris/sumi/collective_message.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// distribution.
1515

1616
#include <iris/sumi/collective_message.h>
17-
#include <mercury/common/serializable.h>
17+
#include <sst/core/serialization/serializable.h>
1818

1919
namespace SST::Iris::sumi {
2020

@@ -34,7 +34,7 @@ CollectiveWorkMessage::tostr(int p)
3434
}
3535

3636
void
37-
CollectiveWorkMessage::serialize_order(SST::Hg::serializer &ser)
37+
CollectiveWorkMessage::serialize_order(SST::Core::Serialization::serializer& ser)
3838
{
3939
ProtocolMessage::serialize_order(ser);
4040
ser & tag_;

src/sst/elements/iris/sumi/collective_message.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include <iris/sumi/message.h>
1919
#include <iris/sumi/collective.h>
2020
#include <mercury/common/thread_safe_new.h>
21+
#include <sst/core/serialization/serializable.h>
2122

2223
namespace SST::Iris::sumi {
2324

@@ -127,7 +128,7 @@ class CollectiveWorkMessage final :
127128

128129
static const char* tostr(int p);
129130

130-
void serialize_order(SST::Hg::serializer& ser) override;
131+
void serialize_order(SST::Core::Serialization::serializer& ser) override;
131132

132133
int tag() const {
133134
return tag_;

src/sst/elements/iris/sumi/message.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Message::tostr(class_t ty)
8181
}
8282

8383
void
84-
Message::serialize_order(SST::Hg::serializer &ser)
84+
Message::serialize_order(SST::Core::Serialization::serializer& ser)
8585
{
8686
ser & arrived_;
8787
ser & recv_sync_delay_;

src/sst/elements/iris/sumi/message.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ Questions? Contact sst-macro-help@sandia.gov
4949
#include <utility>
5050
#include <mercury/common/util.h>
5151
#include <mercury/common/printable.h>
52-
#include <mercury/common/serializable.h>
5352
#include <mercury/common/timestamp.h>
5453
#include <mercury/common/thread_safe_new.h>
5554
#include <mercury/components/operating_system_fwd.h>
5655
#include <mercury/hardware/network/network_message.h>
56+
#include <sst/core/serialization/serializable.h>
5757

5858
namespace SST::Iris::sumi {
5959

@@ -103,9 +103,9 @@ class Message : public SST::Hg::NetworkMessage
103103

104104
std::string toString() const override;
105105

106-
void serialize_order(SST::Hg::serializer &ser) override;
106+
void serialize_order(SST::Core::Serialization::serializer& ser) override;
107107

108-
void serializeBuffers(SST::Hg::serializer& ser);
108+
void serializeBuffers(SST::Core::Serialization::serializer& ser);
109109

110110
static bool needsAck(SST::Hg::NetworkMessage::type_t ty,
111111
int sendCQ, int recvCQ);
@@ -295,7 +295,7 @@ class ProtocolMessage : public Message {
295295
{
296296
}
297297

298-
void serialize_order(SST::Hg::serializer& ser) override {
298+
void serialize_order(SST::Core::Serialization::serializer& ser) override {
299299
Message::serialize_order(ser);
300300
ser & stage_;
301301
ser & protocol_;

src/sst/elements/mercury/Makefile.am

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ nobase_library_include_HEADERS = \
108108
common/event_handler.h \
109109
common/factory.h \
110110
common/node_address.h \
111-
common/serializable.h \
112111
common/stl_string.h \
113112
common/thread_lock.h \
114113
common/thread_safe_int.h \

src/sst/elements/mercury/common/request.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
#pragma once
1717

18-
#include <mercury/common/serializable.h>
1918
#include <mercury/common/printable.h>
2019

2120
namespace SST {

src/sst/elements/mercury/common/serializable.h

Lines changed: 0 additions & 40 deletions
This file was deleted.

src/sst/elements/mercury/common/timestamp.h

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
#pragma once
1717

1818
#include <sst/core/sst_types.h>
19-
#include <mercury/common/serializable.h>
2019
#include <mercury/common/errors.h>
20+
#include <sst/core/serialization/serializable.h>
2121
#include <iosfwd>
2222
#include <stdint.h>
2323
#include <iostream>
@@ -146,6 +146,11 @@ class TimeDelta
146146
TimeDelta& operator-=(const TimeDelta &other);
147147
TimeDelta& operator*=(double scale);
148148
TimeDelta& operator/=(double scale);
149+
150+
void serialize_order(SST::Core::Serialization::serializer& ser) {
151+
SST_SER(ticks_);
152+
}
153+
149154
};
150155

151156
struct Timestamp
@@ -207,6 +212,11 @@ struct Timestamp
207212
static constexpr uint64_t carry_bits_mask = 0;
208213
static constexpr uint64_t remainder_bits_mask = ~uint64_t(0);
209214
static constexpr uint64_t carry_bits_shift = 0;
215+
216+
void serialize_order(SST::Core::Serialization::serializer& ser) {
217+
SST_SER(epochs);
218+
SST_SER(time);
219+
}
210220
};
211221

212222
TimeDelta operator+(const TimeDelta &a, const TimeDelta &b);
@@ -303,21 +313,3 @@ std::string to_printf_type(TimeDelta t);
303313

304314
} // end namespace Hg
305315
} // end namespace SST
306-
307-
START_SERIALIZATION_NAMESPACE
308-
template <> class serialize_impl<SST::Hg::TimeDelta>
309-
{
310-
public:
311-
void operator()(SST::Hg::TimeDelta& t, serializer& ser){
312-
ser.primitive(t);
313-
}
314-
};
315-
316-
template <> class serialize_impl<SST::Hg::Timestamp>
317-
{
318-
public:
319-
void operator()(SST::Hg::Timestamp& t, serializer& ser){
320-
ser.primitive(t);
321-
}
322-
};
323-
END_SERIALIZATION_NAMESPACE

src/sst/elements/mercury/common/unique_id.h

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
#include <sstream>
1919
#include <stdint.h>
20-
#include <mercury/common/serializable.h>
20+
#include <sst/core/serialization/serializable.h>
2121

2222
namespace SST {
2323
namespace Hg {
@@ -70,23 +70,16 @@ struct UniqueEventId {
7070
++msg_num;
7171
return other;
7272
}
73+
74+
void serialize_order(SST::Core::Serialization::serializer& ser) {
75+
SST_SER(src_node);
76+
SST_SER(msg_num);
77+
}
7378
};
7479

7580
} // end namespace Hg
7681
} // end namespace SST
7782

78-
START_SERIALIZATION_NAMESPACE
79-
template <>
80-
class serialize_impl<SST::Hg::UniqueEventId>
81-
{
82-
public:
83-
void
84-
operator()(SST::Hg::UniqueEventId& id, serializer& ser){
85-
ser.primitive(id);
86-
}
87-
};
88-
END_SERIALIZATION_NAMESPACE
89-
9083
namespace std {
9184
template <>
9285
struct hash<SST::Hg::UniqueEventId>

src/sst/elements/mercury/components/nic.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ namespace SST {
2828
namespace Hg {
2929

3030
void
31-
NicEvent::serialize_order(serializer &ser)
31+
NicEvent::serialize_order(SST::Core::Serialization::serializer& ser)
3232
{
3333
Event::serialize_order(ser);
3434
ser & msg_;

0 commit comments

Comments
 (0)