Skip to content

Commit fe58343

Browse files
tiagosilva-pngTiagoMSSantos
tiagosilva-png
authored and
TiagoMSSantos
committed
Remove fat-jars and update dependencies
This commit removes the distribution of fat-jars with all the dependencies because OpenML-Java is a library and thus it's better to distribute it as such, and the project using it, can exclude some dependencies if it requires. It also updates some dependencies, that can be safely updated without breaking anything. It updates: * gson to v2.9.0 * slf4j-api to v1.7.36 * commons-lang3 to v3.13.0 * log4j to v2.20.0
1 parent b3835d9 commit fe58343

3 files changed

Lines changed: 14 additions & 102 deletions

File tree

‎openml-datarobot/pom.xml‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -120,25 +120,4 @@
120120
</dependency>
121121
</dependencies>
122122

123-
<build>
124-
<plugins>
125-
<plugin>
126-
<artifactId>maven-assembly-plugin</artifactId>
127-
<configuration>
128-
<descriptorRefs>
129-
<descriptorRef>jar-with-dependencies</descriptorRef>
130-
</descriptorRefs>
131-
<appendAssemblyId>false</appendAssemblyId>
132-
</configuration>
133-
<executions>
134-
<execution>
135-
<phase>package</phase>
136-
<goals>
137-
<goal>single</goal>
138-
</goals>
139-
</execution>
140-
</executions>
141-
</plugin>
142-
</plugins>
143-
</build>
144123
</project>

‎openml-h2o/pom.xml‎

Lines changed: 0 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -220,75 +220,6 @@
220220

221221
<build>
222222
<plugins>
223-
<plugin>
224-
<artifactId>maven-assembly-plugin</artifactId>
225-
<configuration>
226-
<descriptorRefs>
227-
<descriptorRef>jar-with-dependencies</descriptorRef>
228-
</descriptorRefs>
229-
<appendAssemblyId>false</appendAssemblyId>
230-
</configuration>
231-
<executions>
232-
<execution>
233-
<phase>package</phase>
234-
<goals>
235-
<goal>single</goal>
236-
</goals>
237-
</execution>
238-
</executions>
239-
</plugin>
240-
<plugin>
241-
<groupId>org.apache.maven.plugins</groupId>
242-
<artifactId>maven-shade-plugin</artifactId>
243-
<executions>
244-
<execution>
245-
<phase>package</phase>
246-
<goals>
247-
<goal>shade</goal>
248-
</goals>
249-
<configuration>
250-
<relocations>
251-
<relocation>
252-
<pattern>org.eclipse.jetty</pattern>
253-
<shadedPattern>feedzai.jetty9.shaded.org.eclipse.jetty</shadedPattern>
254-
</relocation>
255-
</relocations>
256-
<filters>
257-
<filter>
258-
<artifact>*:*</artifact>
259-
<excludes>
260-
<exclude>www/**</exclude>
261-
<exclude>META-INF/*.SF</exclude>
262-
<exclude>META-INF/*.DSA</exclude>
263-
<exclude>META-INF/*.RSA</exclude>
264-
<exclude>org/apache/commons/logging/**</exclude>
265-
<exclude>org/slf4j/**</exclude>
266-
<exclude>com/esotericsoftware/kryo/**</exclude>
267-
<exclude>org/objenesis/**</exclude>
268-
<!-- The following two libraries were removed because they were under-performing in cluster environments-->
269-
<exclude>**/libxgboost4j_gpu.so</exclude>
270-
<exclude>**/libxgboost4j_omp.so</exclude>
271-
</excludes>
272-
</filter>
273-
</filters>
274-
<transformers>
275-
<transformer
276-
implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
277-
<!-- Concatenates Log4j2Plugins.dat files in order to provide a workaround for LOG4J2-673 and LOG4J2-954 -->
278-
<transformer
279-
implementation="io.github.edwgiz.log4j.maven.plugins.shade.transformer.Log4j2PluginCacheFileTransformer"/>
280-
</transformers>
281-
</configuration>
282-
</execution>
283-
</executions>
284-
<dependencies>
285-
<dependency>
286-
<groupId>io.github.edwgiz</groupId>
287-
<artifactId>log4j-maven-shade-plugin-extensions</artifactId>
288-
<version>2.17.1</version>
289-
</dependency>
290-
</dependencies>
291-
</plugin>
292223
<!-- allow to use the objects created in test directory from outside of this module -->
293224
<plugin>
294225
<groupId>org.apache.maven.plugins</groupId>

‎pom.xml‎

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
<jackson-databind.version>2.6.7</jackson-databind.version>
7979
<commons-io.version>2.7</commons-io.version>
8080
<apache.version>1.8</apache.version>
81-
<log4j.version>2.17.1</log4j.version>
81+
<log4j.version>2.20.0</log4j.version>
8282
</properties>
8383

8484
<dependencyManagement>
@@ -121,44 +121,51 @@
121121
<groupId>com.fasterxml.jackson.core</groupId>
122122
<artifactId>jackson-core</artifactId>
123123
<version>${jackson.version}</version>
124-
<scope>provided</scope>
125124
</dependency>
126125
<dependency>
127126
<groupId>com.fasterxml.jackson.core</groupId>
128127
<artifactId>jackson-annotations</artifactId>
129128
<version>${jackson.version}</version>
130-
<scope>provided</scope>
131129
</dependency>
132130
<dependency>
133131
<groupId>com.fasterxml.jackson.core</groupId>
134132
<artifactId>jackson-databind</artifactId>
135133
<version>${jackson-databind.version}</version>
136-
<scope>provided</scope>
137134
</dependency>
138135

139136
<dependency>
140137
<groupId>com.google.code.gson</groupId>
141138
<artifactId>gson</artifactId>
142-
<version>2.8.9</version>
139+
<version>2.9.0</version>
143140
</dependency>
144141

145142
<dependency>
146143
<groupId>org.slf4j</groupId>
147144
<artifactId>slf4j-api</artifactId>
148-
<version>1.7.25</version>
145+
<version>1.7.36</version>
149146
</dependency>
150147

151148
<dependency>
152149
<groupId>org.apache.commons</groupId>
153150
<artifactId>commons-lang3</artifactId>
154-
<version>3.7</version>
151+
<version>3.13.0</version>
155152
</dependency>
156153

157154
<dependency>
158155
<groupId>org.apache.logging.log4j</groupId>
159156
<artifactId>log4j-core</artifactId>
160157
<version>${log4j.version}</version>
161158
</dependency>
159+
<dependency>
160+
<groupId>org.apache.logging.log4j</groupId>
161+
<artifactId>log4j-api</artifactId>
162+
<version>${log4j.version}</version>
163+
</dependency>
164+
<dependency>
165+
<groupId>org.apache.logging.log4j</groupId>
166+
<artifactId>log4j-1.2-api</artifactId>
167+
<version>${log4j.version}</version>
168+
</dependency>
162169

163170
<!--Testing-->
164171
<dependency>
@@ -222,11 +229,6 @@
222229
<artifactId>maven-assembly-plugin</artifactId>
223230
<version>2.5.3</version>
224231
</plugin>
225-
<plugin>
226-
<groupId>org.apache.maven.plugins</groupId>
227-
<artifactId>maven-shade-plugin</artifactId>
228-
<version>3.2.4</version>
229-
</plugin>
230232
<plugin>
231233
<groupId>org.apache.maven.plugins</groupId>
232234
<artifactId>maven-install-plugin</artifactId>

0 commit comments

Comments
 (0)