[BUG]: Spellcheck in code field in edit mode

[timomen]

Describe the bug

A spellcheck red line appears in keywords in code blocks. useful for grammar, but not for code. This does not appear in non-edit mode and markdown editing mode

This is not the expected outcome as much text in code will be seen as a typo though it is not.

Steps to Reproduce

1. Go into notes
2. Open a note and go into edit mode
3. Switch to Rich Text mode
4. Click anywhere on text in the code block
5. See red underline

How do you run Jotty?

Docker

Jotty Version

1.20.0 (latest)

Checklist

• I have searched across other issues to make sure this bug has not been already reported.

[fccview]

Hi @timomen
That does not come from Jotty, I don't have any spell check in the codebase.

This is just standard browser behaviour, I can try and see if there's some way to remove browser native spellcheck, but no promises for now.

Just for comparison I'll show you a screenshot from github too:

[FibreTTP]

This is just standard browser behaviour

I believe that's their point.

In markdown editing mode, Jotty suggests to the browser that spellcheck should be disabled for that text input field:

In rich text, it is enabled:

Which is okay, since rich text is by design plain language input... but code blocks aren't.

This can be fixed by setting spellcheck="false" to the appropriate HTML element responsible for displaying code blocks. To test locally, I added it to the <code> element:

I don't have a clue about React, TypeScript, whatever, so I'm gonna assume it would go somewhere... here?

jotty/app/_components/FeatureComponents/Notes/Parts/CodeBlock/CodeBlockRenderer.tsx

Lines 103 to 107 in 25af7c4

	<pre
	className={`!bg-transparent !p-4 !m-0 overflow-x-auto text-md lg:text-sm flex-1 language-${language}`}
	>
	{children}
	</pre>

edit: remember that spellcheck is a global attribute, so it can go as high up as necessary

[fccview]

Thank you @FibreTTP

I was actually thinking about having some syntax specific spell check which is why I left this for a while, that's an elegant easy solution for now tho, so I can try and squeeze it into next major release ♥️

Things are a bit slow currently, so not sure when that'll be .

I have a small bugfixes release planned for today together with an update about the personal situation mentioned in the latest release ♥️