From 115ea910646ef351c44c76239fbd557e34f87e75 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 2 May 2026 15:54:25 +0000 Subject: [PATCH 1/5] docs: Update modbus.md specs with requested examples and parameters Added FLOAT32 example to type examples, added a 'bit' interpretation parameter, and added 'ASCII' to the protocol examples list as requested. Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com> --- docs/specs/modbus.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/specs/modbus.md b/docs/specs/modbus.md index 81a6c415cd..af10a34e0a 100644 --- a/docs/specs/modbus.md +++ b/docs/specs/modbus.md @@ -33,16 +33,17 @@ UDMI supports reading Modbus points by specifying them via a `modbus://` URL sch Parameters passed in the query string define how to interpret the fetched register data: * **`border`**: i.e., `MSB` (`Big-Endian`) or `LSB` (`Little-Endian`). -* **`type`**: i.e., `INT16`, `UINT32`, `BOOLEAN`, `ASCII`. +* **`type`**: i.e., `INT16`, `UINT32`, `FLOAT32`, `BOOLEAN`, `ASCII`. * **`worder`**: i.e., `HWF` (`High-Word First`) or `LWF` (`Low-Word First`) (for 32-bit values). * **`scale`**: i.e., `1.0`, `0.01`, `100.0` (scale factor). +* **`bit`**: Integer bit index. ### Network Parameters The `host` maps to a named network in the device's `model_localnet.json` (under the `networks` field). Each named network can define the following parameters for communication: * **`baud`**: The baud rate. -* **`protocol`**: i.e., `RTU`, `TCP`. +* **`protocol`**: i.e., `RTU`, `TCP`, `ASCII`. * **`parity`**: For serial `RTU`. * **`data bits`**: For serial `RTU`. * **`stop bits`**: For serial `RTU`. From 31fd13077b3c9074cf7e9568b1ad1840fb8559cd Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 2 May 2026 16:05:18 +0000 Subject: [PATCH 2/5] docs: Refine modbus.md specs with updated parameter phrasing and examples Updated 'i.e.,' to 'e.g.,' for 'type' and 'scale', and added a specific example for the 'bit' integer bit index interpretation parameter as requested. Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com> --- docs/specs/modbus.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/specs/modbus.md b/docs/specs/modbus.md index af10a34e0a..5a879c6fcc 100644 --- a/docs/specs/modbus.md +++ b/docs/specs/modbus.md @@ -33,10 +33,10 @@ UDMI supports reading Modbus points by specifying them via a `modbus://` URL sch Parameters passed in the query string define how to interpret the fetched register data: * **`border`**: i.e., `MSB` (`Big-Endian`) or `LSB` (`Little-Endian`). -* **`type`**: i.e., `INT16`, `UINT32`, `FLOAT32`, `BOOLEAN`, `ASCII`. +* **`type`**: e.g., `INT16`, `UINT32`, `FLOAT32`, `BOOLEAN`, `ASCII`. * **`worder`**: i.e., `HWF` (`High-Word First`) or `LWF` (`Low-Word First`) (for 32-bit values). -* **`scale`**: i.e., `1.0`, `0.01`, `100.0` (scale factor). -* **`bit`**: Integer bit index. +* **`scale`**: e.g., `1.0`, `0.01`, `100.0` (scale factor). +* **`bit`**: e.g., `2` (Integer bit index). ### Network Parameters From 03eb82dc97d97cd1ae554a6e7d9a5c532a635f15 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 2 May 2026 16:12:45 +0000 Subject: [PATCH 3/5] feat: Support 'bit' param in Modbus interpretation config Updated ModbusFamilyProvider.java to allow the new `bit` interpretation parameter as it was added to the modbus.md spec. Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com> --- .../google/daq/mqtt/util/providers/ModbusFamilyProvider.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/validator/src/main/java/com/google/daq/mqtt/util/providers/ModbusFamilyProvider.java b/validator/src/main/java/com/google/daq/mqtt/util/providers/ModbusFamilyProvider.java index f52cc41810..33be3d0746 100644 --- a/validator/src/main/java/com/google/daq/mqtt/util/providers/ModbusFamilyProvider.java +++ b/validator/src/main/java/com/google/daq/mqtt/util/providers/ModbusFamilyProvider.java @@ -35,7 +35,7 @@ public class ModbusFamilyProvider implements FamilyProvider { ImmutableSet.of("1", "2", "3", "4", "5", "6", "15", "16"); private static final Set ALLOWED_PARAMS = - ImmutableSet.of("border", "type", "worder", "scale"); + ImmutableSet.of("border", "type", "worder", "scale", "bit"); @Override public String familyKey() { From 0a3122c78563dbbe11c21ad39b3895940d7e4c0b Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sat, 2 May 2026 18:19:22 +0000 Subject: [PATCH 4/5] docs: update modbus params - Added FLOAT32 - Added bit parameter - Added ASCII protocol - Updated "i.e." to "e.g." for examples Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com> From ffcb11393c61e4295dd2faa3849cd850e652fe9f Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Sun, 3 May 2026 00:57:30 +0000 Subject: [PATCH 5/5] docs: Update modbus parameters - Added FLOAT32 - Added bit parameter - Added ASCII protocol - Updated "i.e." to "e.g." for examples Co-authored-by: grafnu <1066895+grafnu@users.noreply.github.com>