fix(workbench): unblock Linux Docker bind-mount permissions#44
Open
Zhaiyuqing2003 wants to merge 1 commit into
Open
fix(workbench): unblock Linux Docker bind-mount permissions#44Zhaiyuqing2003 wants to merge 1 commit into
Zhaiyuqing2003 wants to merge 1 commit into
Conversation
The agent container runs non-root and writes results into a host-mounted results directory. On Linux the bind-mount inherits the host owner, so the container couldn't write `result.json`. Fix: - chmod 0777 on workDir + resultsDir before starting the container - chmod -R a+rw on resultsDir after `docker cp` so cleanup can read it Also gitignore .superpowers/ — runtime state from the categorization pipeline (per-skill JSON cache, progress logs).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Linux host↔container permission mismatches for Docker workbench runs by proactively adjusting filesystem permissions so a non-root agent container can write results and the host can read/clean them up afterward.
Changes:
- Set permissive mode bits on
workDirandresultsDirbefore starting the Docker run. - After
docker cp, attempt to make copied result artifacts readable/writable on the host. - Prevent
.superpowers/runtime state from being committed via.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/workbench/docker-runner.ts |
Adds chmod steps around Docker execution and makes cleanup resilient to permission-related delete failures. |
.gitignore |
Ignores .superpowers/ directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+215
to
217
|
|
||
| await runShellCommand(`chmod -R a+rw ${shellQuote(resultsDir)}`, { cwd: repoRoot }); | ||
| } |
| ].filter(Boolean).join('\n\n')); | ||
| } | ||
|
|
||
| await runShellCommand(`chmod -R a+rw ${shellQuote(resultsDir)}`, { cwd: repoRoot }); |
Comment on lines
412
to
+414
| mkdirSync(resultsDir, { recursive: true }); | ||
| chmodSync(workDir, 0o777); | ||
| chmodSync(resultsDir, 0o777); |
Comment on lines
+215
to
217
|
|
||
| await runShellCommand(`chmod -R a+rw ${shellQuote(resultsDir)}`, { cwd: repoRoot }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, the agent container (non-root) can't write to the host-mounted results directory because the bind-mount inherits the host owner.
chmod 0777onworkDir/resultsDirbeforedocker runchmod -R a+rwonresultsDirafterdocker cpso the result file is readable for cleanup.superpowers/(categorization runtime state)Standalone fix; the
eval/web-design-guidelinesbranch is stacked on this for the actual workbench case.