This repository was archived by the owner on Apr 24, 2026. It is now read-only.
fix(kill_switch): expiry boundary off-by-one (>= → >)#155
Open
levleontiev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Line 124 of
src/fairvisor/kill_switch.luaused>=when comparing against the current time:This keeps a kill switch active at the exact expiry second, contrary to standard expiry semantics (JWT
exp, HTTP cookies, ISO 8601 intervals) where the expiry timestamp is the first moment the resource is no longer valid.Fix
Change
>=to>:Tests
Added AC-13 to
spec/unit/features/kill_switch.feature:Existing AC-5 (1s after expiry → not matched) and AC-6 (1s before → matched) continue to pass.