Skip to content

Commit f230b0c

Browse files
ahmadelyousseffacebook-github-bot
authored andcommitted
Reverting ucache_bench gen updates
Summary: Reverting ucache_bench gen updates Differential Revision: D95604666
1 parent af3e3b1 commit f230b0c

4 files changed

Lines changed: 269 additions & 7 deletions

File tree

packages/ucache_bench/protocol/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ set(PROTOCOL_HEADERS
153153
gen/UcacheBenchMessages-inl.h
154154
gen/UcacheBenchRouteHandleIf.h
155155
gen/UcacheBenchRouterInfo.h
156+
gen/UcacheBenchRouterInfoFwd.h
156157
gen/UcacheBenchRouterStats.h
157158
gen/UcacheBenchRoutingGroups.h
158159
gen/UcacheBenchServer.h

packages/ucache_bench/protocol/gen/UcacheBench.thrift

Lines changed: 116 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,61 @@ namespace cpp2 facebook.ucachebench.thrift
2424
namespace py3 facebook.ucachebench.thrift
2525
namespace hack ucachebench
2626

27+
@thrift.DeprecatedUnvalidatedAnnotations{
28+
items = {
29+
"cpp.methods": "
30+
template <class V>
31+
void visitFields(V&& v);
32+
template <class V>
33+
void visitFields(V&& v) const;
34+
35+
template <class Writer>
36+
void serialize(Writer&& writer) const;
37+
38+
void deserialize(carbon::CarbonProtocolReader& reader);
39+
40+
"
41+
},
42+
}
2743
struct UcacheBenchRequestCommon {
2844
1: optional i64 productId
2945
2: optional string bucketId
3046
}
47+
@thrift.DeprecatedUnvalidatedAnnotations{
48+
items = {
49+
"cpp.methods": "
50+
template <class V>
51+
void visitFields(V&& v);
52+
template <class V>
53+
void visitFields(V&& v) const;
54+
55+
template <class Writer>
56+
void serialize(Writer&& writer) const;
57+
58+
void deserialize(carbon::CarbonProtocolReader& reader);
59+
60+
"
61+
},
62+
}
3163
struct UcacheBenchReplyCommon {
3264
1: carbon.ui32 replySourceBitMask
3365
}
3466
@thrift.DeprecatedUnvalidatedAnnotations{
3567
items = {
36-
"cpp.virtual": "1"
68+
"cpp.methods": "
69+
template <class V>
70+
void visitFields(V&& v);
71+
template <class V>
72+
void visitFields(V&& v) const;
73+
74+
template <class Writer>
75+
void serialize(Writer&& writer) const;
76+
77+
void deserialize(carbon::CarbonProtocolReader& reader);
78+
79+
",
80+
"cpp.virtual": "1"
81+
3782
},
3883
}
3984
struct UcbGetRequest {
@@ -44,7 +89,20 @@ struct UcbGetRequest {
4489
}
4590
@thrift.DeprecatedUnvalidatedAnnotations{
4691
items = {
47-
"cpp.virtual": "1"
92+
"cpp.methods": "
93+
template <class V>
94+
void visitFields(V&& v);
95+
template <class V>
96+
void visitFields(V&& v) const;
97+
98+
template <class Writer>
99+
void serialize(Writer&& writer) const;
100+
101+
void deserialize(carbon::CarbonProtocolReader& reader);
102+
103+
",
104+
"cpp.virtual": "1"
105+
48106
},
49107
}
50108
struct UcbGetReply {
@@ -59,7 +117,20 @@ struct UcbGetReply {
59117
}
60118
@thrift.DeprecatedUnvalidatedAnnotations{
61119
items = {
62-
"cpp.virtual": "1"
120+
"cpp.methods": "
121+
template <class V>
122+
void visitFields(V&& v);
123+
template <class V>
124+
void visitFields(V&& v) const;
125+
126+
template <class Writer>
127+
void serialize(Writer&& writer) const;
128+
129+
void deserialize(carbon::CarbonProtocolReader& reader);
130+
131+
",
132+
"cpp.virtual": "1"
133+
63134
},
64135
}
65136
struct UcbSetRequest {
@@ -72,7 +143,20 @@ struct UcbSetRequest {
72143
}
73144
@thrift.DeprecatedUnvalidatedAnnotations{
74145
items = {
75-
"cpp.virtual": "1"
146+
"cpp.methods": "
147+
template <class V>
148+
void visitFields(V&& v);
149+
template <class V>
150+
void visitFields(V&& v) const;
151+
152+
template <class Writer>
153+
void serialize(Writer&& writer) const;
154+
155+
void deserialize(carbon::CarbonProtocolReader& reader);
156+
157+
",
158+
"cpp.virtual": "1"
159+
76160
},
77161
}
78162
struct UcbSetReply {
@@ -86,7 +170,20 @@ struct UcbSetReply {
86170
}
87171
@thrift.DeprecatedUnvalidatedAnnotations{
88172
items = {
89-
"cpp.virtual": "1"
173+
"cpp.methods": "
174+
template <class V>
175+
void visitFields(V&& v);
176+
template <class V>
177+
void visitFields(V&& v) const;
178+
179+
template <class Writer>
180+
void serialize(Writer&& writer) const;
181+
182+
void deserialize(carbon::CarbonProtocolReader& reader);
183+
184+
",
185+
"cpp.virtual": "1"
186+
90187
},
91188
}
92189
struct UcbDeleteRequest {
@@ -97,7 +194,20 @@ struct UcbDeleteRequest {
97194
}
98195
@thrift.DeprecatedUnvalidatedAnnotations{
99196
items = {
100-
"cpp.virtual": "1"
197+
"cpp.methods": "
198+
template <class V>
199+
void visitFields(V&& v);
200+
template <class V>
201+
void visitFields(V&& v) const;
202+
203+
template <class Writer>
204+
void serialize(Writer&& writer) const;
205+
206+
void deserialize(carbon::CarbonProtocolReader& reader);
207+
208+
",
209+
"cpp.virtual": "1"
210+
101211
},
102212
}
103213
struct UcbDeleteReply {
@@ -108,4 +218,3 @@ struct UcbDeleteReply {
108218
3: string message
109219
4: i16 appSpecificErrorCode
110220
}
111-

0 commit comments

Comments
 (0)