Fix return type for Bridging::fromJs (#56246)

coado · meta-codesync[bot] · commit 82b624f653b0 · 2026-03-27T04:12:10.000-07:00
Summary: Pull Request resolved: #56246 Fixes return type to receive correct generic types. Before: ``` static std::pair<T1, T1> fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr<CallInvoker> &jsInvoker) ``` After: ``` static std::pair<T1, T2> fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr<CallInvoker> &jsInvoker) ``` Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D98292820
diff --git a/packages/react-native/ReactCommon/react/bridging/Array.h b/packages/react-native/ReactCommon/react/bridging/Array.h
@@ -76,7 +76,7 @@ struct Bridging<std::array<T, N>> : array_detail::BridgingStatic<std::array<T, N
 
 template <typename T1, typename T2>
 struct Bridging<std::pair<T1, T2>> : array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  static std::pair<T1, T1>
+  static std::pair<T1, T2>
   fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr<CallInvoker> &jsInvoker)
   {
     return std::make_pair(
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
@@ -10416,7 +10416,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
@@ -10243,7 +10243,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
@@ -12874,7 +12874,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
@@ -12701,7 +12701,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
@@ -7179,7 +7179,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
@@ -7170,7 +7170,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ struct Bridging<std::array<T, N>> : array_detail::BridgingStatic<std::array<T, N`
`76`	`76`
`77`	`77`	`template <typename T1, typename T2>`
`78`	`78`	`struct Bridging<std::pair<T1, T2>> : array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`79`		`- static std::pair<T1, T1>`
	`79`	`+ static std::pair<T1, T2>`
`80`	`80`	`fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr<CallInvoker> &jsInvoker)`
`81`	`81`	`{`
`82`	`82`	`return std::make_pair(`
Original file line number	Diff line number	Diff line change
`@@ -10416,7 +10416,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`10416`	`10416`
`10417`	`10417`	`template <typename T1, typename T2>`
`10418`	`10418`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`10419`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`10419`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`10420`	`10420`	`}`
`10421`	`10421`
`10422`	`10422`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -10243,7 +10243,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`10243`	`10243`
`10244`	`10244`	`template <typename T1, typename T2>`
`10245`	`10245`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`10246`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`10246`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`10247`	`10247`	`}`
`10248`	`10248`
`10249`	`10249`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -12874,7 +12874,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`12874`	`12874`
`12875`	`12875`	`template <typename T1, typename T2>`
`12876`	`12876`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`12877`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`12877`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`12878`	`12878`	`}`
`12879`	`12879`
`12880`	`12880`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -12701,7 +12701,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`12701`	`12701`
`12702`	`12702`	`template <typename T1, typename T2>`
`12703`	`12703`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`12704`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`12704`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`12705`	`12705`	`}`
`12706`	`12706`
`12707`	`12707`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -7179,7 +7179,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`7179`	`7179`
`7180`	`7180`	`template <typename T1, typename T2>`
`7181`	`7181`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`7182`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`7182`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`7183`	`7183`	`}`
`7184`	`7184`
`7185`	`7185`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -7170,7 +7170,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`7170`	`7170`
`7171`	`7171`	`template <typename T1, typename T2>`
`7172`	`7172`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`7173`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`7173`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`7174`	`7174`	`}`
`7175`	`7175`
`7176`	`7176`	`template <typename T, size_t N>`