Fix return type for Bridging::fromJs

coado · meta-codesync[bot] · commit 4d3fc9a63480 · 2026-03-27T02:25:31.000-07:00
Summary:
Fixes return type to receive correct generic types.

Before:
```
static std::pair&lt;T1, T1&gt;
  fromJs(facebook::jsi::Runtime &amp;rt, const jsi::Array &amp;array, const std::shared_ptr&lt;CallInvoker&gt; &amp;jsInvoker)
```

After:
```
static std::pair&lt;T1, T2&gt;
  fromJs(facebook::jsi::Runtime &amp;rt, const jsi::Array &amp;array, const std::shared_ptr&lt;CallInvoker&gt; &amp;jsInvoker)
```

Changelog:
[Internal]

Differential Revision: D98292820
diff --git a/packages/react-native/ReactCommon/react/bridging/Array.h b/packages/react-native/ReactCommon/react/bridging/Array.h
@@ -76,7 +76,7 @@ struct Bridging<std::array<T, N>> : array_detail::BridgingStatic<std::array<T, N
 
 template <typename T1, typename T2>
 struct Bridging<std::pair<T1, T2>> : array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  static std::pair<T1, T1>
+  static std::pair<T1, T2>
   fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr<CallInvoker> &jsInvoker)
   {
     return std::make_pair(
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
@@ -10420,7 +10420,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
@@ -10247,7 +10247,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
@@ -12876,7 +12876,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
@@ -12703,7 +12703,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
@@ -7181,7 +7181,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
@@ -7172,7 +7172,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {
 
 template <typename T1, typename T2>
 struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {
-  public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
+  public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);
 }
 
 template <typename T, size_t N>

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ struct Bridging<std::array<T, N>> : array_detail::BridgingStatic<std::array<T, N`
`76`	`76`
`77`	`77`	`template <typename T1, typename T2>`
`78`	`78`	`struct Bridging<std::pair<T1, T2>> : array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`79`		`- static std::pair<T1, T1>`
	`79`	`+ static std::pair<T1, T2>`
`80`	`80`	`fromJs(facebook::jsi::Runtime &rt, const jsi::Array &array, const std::shared_ptr<CallInvoker> &jsInvoker)`
`81`	`81`	`{`
`82`	`82`	`return std::make_pair(`
Original file line number	Diff line number	Diff line change
`@@ -10420,7 +10420,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`10420`	`10420`
`10421`	`10421`	`template <typename T1, typename T2>`
`10422`	`10422`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`10423`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`10423`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`10424`	`10424`	`}`
`10425`	`10425`
`10426`	`10426`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -10247,7 +10247,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`10247`	`10247`
`10248`	`10248`	`template <typename T1, typename T2>`
`10249`	`10249`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`10250`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`10250`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`10251`	`10251`	`}`
`10252`	`10252`
`10253`	`10253`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -12876,7 +12876,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`12876`	`12876`
`12877`	`12877`	`template <typename T1, typename T2>`
`12878`	`12878`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`12879`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`12879`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`12880`	`12880`	`}`
`12881`	`12881`
`12882`	`12882`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -12703,7 +12703,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`12703`	`12703`
`12704`	`12704`	`template <typename T1, typename T2>`
`12705`	`12705`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`12706`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`12706`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`12707`	`12707`	`}`
`12708`	`12708`
`12709`	`12709`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -7181,7 +7181,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`7181`	`7181`
`7182`	`7182`	`template <typename T1, typename T2>`
`7183`	`7183`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`7184`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`7184`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`7185`	`7185`	`}`
`7186`	`7186`
`7187`	`7187`	`template <typename T, size_t N>`
Original file line number	Diff line number	Diff line change
`@@ -7172,7 +7172,7 @@ struct facebook::react::Bridging<std::function<R(Args...)>> {`
`7172`	`7172`
`7173`	`7173`	`template <typename T1, typename T2>`
`7174`	`7174`	`struct facebook::react::Bridging<std::pair<T1, T2>> : public facebook::react::array_detail::BridgingStatic<std::pair<T1, T2>, 2> {`
`7175`		`- public static std::pair<T1, T1> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
	`7175`	`+ public static std::pair<T1, T2> fromJs(facebook::jsi::Runtime& rt, const facebook::jsi::Array& array, const std::shared_ptr<facebook::react::CallInvoker>& jsInvoker);`
`7176`	`7176`	`}`
`7177`	`7177`
`7178`	`7178`	`template <typename T, size_t N>`