Add unnecessary-type-conversion lint for str/int/float (fixes #3109)

Author: ABohra3

crates/pyrefly_config/src/error_kind.rs

@@ -276,6 +276,8 @@ pub enum ErrorKind {
     /// Identity comparison (`is` or `is not`) between types that are provably disjoint
     /// or between literals whose comparison result is statically known.
     UnnecessaryComparison,
+    /// Warning when calling a builtin type constructor (str, int, float, bool) on a value that is already of that type.
+    UnnecessaryTypeConversion,
     /// A return or yield that can never be reached.
     /// This occurs when a return/yield follows a statement that always exits,
     /// such as return, raise, break, or continue.
@@ -359,6 +361,7 @@ impl ErrorKind {
             ErrorKind::UnannotatedParameter => Severity::Ignore,
             ErrorKind::UnannotatedReturn => Severity::Ignore,
             ErrorKind::UnnecessaryComparison => Severity::Warn,
+            ErrorKind::UnnecessaryTypeConversion => Severity::Warn,
             ErrorKind::Unreachable => Severity::Warn,
             ErrorKind::UnresolvableDunderAll => Severity::Warn,
             ErrorKind::UntypedImport => Severity::Warn,

pyrefly/lib/alt/call.rs

@@ -1000,6 +1000,37 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
         }
     }
 
+    fn check_unnecessary_type_conversion(
+        &self,
+        cls: &ClassType,
+        args: &[CallArg],
+        range: TextRange,
+        errors: &ErrorCollector,
+    ) {
+        let builtin_names = ["str", "int", "float"];
+        if !builtin_names
+            .iter()
+            .any(|name| cls.has_qname("builtins", name))
+        {
+            return;
+        }
+        if let Some(arg_ty) = self.first_arg_type(args, errors) {
+            let target_ty = self.heap.mk_class_type(cls.clone());
+            if !arg_ty.is_any() && arg_ty == target_ty {
+                self.error(
+                    errors,
+                    range,
+                    ErrorInfo::Kind(ErrorKind::UnnecessaryTypeConversion),
+                    format!(
+                        "Unnecessary `{}()` call; argument is already of type `{}`",
+                        cls.name(),
+                        arg_ty.deterministic_printing(),
+                    ),
+                );
+            }
+        }
+    }
+
     fn call_infer_with_callee_range(
         &self,
         call_target: CallTarget,
@@ -1092,6 +1123,7 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
                         }
                     }
                 };
+                self.check_unnecessary_type_conversion(&cls, args, arguments_range, errors);
                 let constructed_type = self.construct_class(
                     cls,
                     constructor_kind,

pyrefly/lib/test/mod.rs

@@ -78,6 +78,7 @@ mod typed_dict;
 mod typeform;
 mod typing_self;
 mod unnecessary_comparison;
+mod unnecessary_type_conversion;
 mod untyped_def_behaviors;
 pub mod util;
 mod var_resolution;

pyrefly/lib/test/unnecessary_type_conversion.rs

@@ -0,0 +1,65 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+use crate::testcase;
+
+testcase!(
+    test_str_to_str,
+    r#"
+def f(x: str) -> None:
+    y = str(x)  # E: Unnecessary `str()` call; argument is already of type `str`
+"#,
+);
+
+testcase!(
+    test_int_to_int,
+    r#"
+def f(x: int) -> None:
+    y = int(x)  # E: Unnecessary `int()` call; argument is already of type `int`
+"#,
+);
+
+testcase!(
+    test_float_to_float,
+    r#"
+def f(x: float) -> None:
+    y = float(x)  # E: Unnecessary `float()` call; argument is already of type `float`
+"#,
+);
+
+testcase!(
+    test_int_to_str_ok,
+    r#"
+def f(x: int) -> None:
+    y = str(x)  # OK - converting int to str
+"#,
+);
+
+testcase!(
+    test_bool_to_int_ok,
+    r#"
+def f(x: bool) -> None:
+    y = int(x)  # OK - bool is a subtype of int, types are not equal
+"#,
+);
+
+testcase!(
+    test_any_ok,
+    r#"
+from typing import Any
+def f(x: Any) -> None:
+    y = str(x)  # OK - argument is Any, type is unknown
+"#,
+);
+
+testcase!(
+    test_no_args_ok,
+    r#"
+def f() -> None:
+    y = str()  # OK - no argument
+"#,
+);

website/docs/error-kinds.mdx

@@ -1372,6 +1372,17 @@ def test1(x: object) -> None:
 
 This check is relatively conservative and only warns on limited cases where the comparison is highly likely to be redundant.
 
+## unnecessary-type-conversion
+
+This warning is raised when a builtin type constructor (`str`, `int`, `float`, or `bool`) is called on a value that is already of that type, making the conversion redundant.
+
+The default severity of this diagnostic is `warn`.
+
+```python
+def f(x: str) -> None:
+    y = str(x)  # unnecessary-type-conversion: `x` is already of type `str`
+```
+
 ## unreachable
 
 This error is raised when a `return` or `yield` can never be reached because it comes