From 58e2f9ad0d5fc3ef3607f0c53e15063b3375d267 Mon Sep 17 00:00:00 2001 From: marif-nexthop Date: Tue, 30 Dec 2025 15:12:54 -0800 Subject: [PATCH 1/3] NO-ISS: Added "biosdevname=0 net.ifnames=0" kernel commandline args to FBOSS image (#243) **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` We noticed that the management interface name on `wdg101` after PXE booting one of our FBOSS distro images changed to `eno1`. The Accton SW has it as `eth0` which is the default in some FBOSS tests too. I looked at the difference and found that in our FBOSS distro image we are not passing `biosdevname=0 net.ifnames=0` kernel commandline args while Accton's linux image is passing it. These two kernel arguments are used to disable `Predictable Network Interface Naming` which names interfaces like `eno1`. Tested by modifying kernel commandline args on Wedge800 (`wdg101`) and verifying that the interface is listed at `eth0` and not `eno1`. --- fboss-image/image_builder/templates/centos-09.0/config.xml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fboss-image/image_builder/templates/centos-09.0/config.xml b/fboss-image/image_builder/templates/centos-09.0/config.xml index 3b3346b2e1c1e..1dfbdda7c8ebe 100644 --- a/fboss-image/image_builder/templates/centos-09.0/config.xml +++ b/fboss-image/image_builder/templates/centos-09.0/config.xml @@ -28,10 +28,9 @@ initrd_system="dracut" primary="true" installiso="true" - bootpartition="true" - bootfilesystem="ext4" - kernelcmdline="nomodeset console=ttyS4,57600n8 quiet rootfstype=btrfs"> - + bootpartition="false" + editbootinstall="editbootinstall.sh" + kernelcmdline="nomodeset console=ttyS4,57600n8 biosdevname=0 net.ifnames=0 quiet rootfstype=btrfs"> 16 From 213b4226064ff4839814c9676090ab679e28aa75 Mon Sep 17 00:00:00 2001 From: marif-nexthop Date: Wed, 31 Dec 2025 10:33:24 -0800 Subject: [PATCH 2/3] Deleted extra changes that were included during file merge. --- fboss-image/image_builder/templates/centos-09.0/config.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fboss-image/image_builder/templates/centos-09.0/config.xml b/fboss-image/image_builder/templates/centos-09.0/config.xml index 1dfbdda7c8ebe..08c4bc7d2cb68 100644 --- a/fboss-image/image_builder/templates/centos-09.0/config.xml +++ b/fboss-image/image_builder/templates/centos-09.0/config.xml @@ -28,8 +28,8 @@ initrd_system="dracut" primary="true" installiso="true" - bootpartition="false" - editbootinstall="editbootinstall.sh" + bootpartition="true" + bootfilesystem="ext4" kernelcmdline="nomodeset console=ttyS4,57600n8 biosdevname=0 net.ifnames=0 quiet rootfstype=btrfs"> 16 From a13c2a65fdcf1abd6d63f4aea4d3289d42f7de68 Mon Sep 17 00:00:00 2001 From: marif-nexthop Date: Wed, 31 Dec 2025 10:35:03 -0800 Subject: [PATCH 3/3] Added back the blank line from the original code. --- fboss-image/image_builder/templates/centos-09.0/config.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/fboss-image/image_builder/templates/centos-09.0/config.xml b/fboss-image/image_builder/templates/centos-09.0/config.xml index 08c4bc7d2cb68..263d79538be9f 100644 --- a/fboss-image/image_builder/templates/centos-09.0/config.xml +++ b/fboss-image/image_builder/templates/centos-09.0/config.xml @@ -31,6 +31,7 @@ bootpartition="true" bootfilesystem="ext4" kernelcmdline="nomodeset console=ttyS4,57600n8 biosdevname=0 net.ifnames=0 quiet rootfstype=btrfs"> + 16