Skip to content

Adopt crap-java 0.2.0#20

Merged
fabian-barney merged 1 commit into
masterfrom
codex/19-adopt-crap-java-0-2-0
Mar 29, 2026
Merged

Adopt crap-java 0.2.0#20
fabian-barney merged 1 commit into
masterfrom
codex/19-adopt-crap-java-0-2-0

Conversation

@fabian-barney

Copy link
Copy Markdown
Owner

Summary

  • adopt the released crap-java 0.2.0 Maven plugin coordinates and package URL
  • rename the local property and workflow command from crap4java to crap-java
  • keep the existing PR test split while pointing the CRAP gate at crap-java:check

Testing

  • ./mvnw -B -ntp test
  • ./mvnw -B -ntp crap-java:check

Closes #19

Copilot AI review requested due to automatic review settings March 29, 2026 14:00
@fabian-barney

Copy link
Copy Markdown
Owner Author

@copilot Please do a code review here. Do not work on the code.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s CRAP quality gate integration to the renamed/released crap-java Maven plugin (0.2.0), aligning build configuration and CI workflow with the new coordinates and goal prefix.

Changes:

  • Bump Maven plugin version property from the old crap4java naming to crap-java and update the GitHub Packages plugin repository URL.
  • Update the configured Maven plugin artifactId to crap-java-maven-plugin.
  • Rename the PR workflow job/command to run crap-java:check under the new crap-java job id.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pom.xml Switches plugin repo URL, property name, artifactId, and version reference to crap-java v0.2.0.
.github/workflows/pr-tests.yml Renames the gate job and updates the Maven goal invocation to crap-java:check.

Copilot AI commented Mar 29, 2026

Copy link
Copy Markdown

@copilot Please do a code review here. Do not work on the code.

Reviewed commit df2723b. I don’t see any blocking issues in the rename from crap4java to crap-java: the Maven property, plugin coordinates, package URL, workflow job id, and Maven goal invocation are all updated consistently. One note from validation: local ./mvnw ... runs in this sandbox fail on GitHub Packages auth when resolving the plugin, but that appears to be an environment/credentials limitation rather than a regression in this PR.

@fabian-barney fabian-barney merged commit c345f56 into master Mar 29, 2026
10 checks passed
@fabian-barney fabian-barney deleted the codex/19-adopt-crap-java-0-2-0 branch April 3, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt crap-java 0.2.0

3 participants