Expose CRAP metrics in GitLab-visible JUnit XML fields#198
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the JUnit XML “sidecar” output to surface CRAP/complexity/coverage details in GitLab-visible JUnit fields (notably the testcase name and testcase-level system-out), while preserving the existing JUnit properties and existing failure/skipped body text behavior. This aligns the tool’s output with GitLab’s Tests tab parsing limitations described in issue #197.
Changes:
- Extend JUnit testcase
nameto include a concise metrics summary (CRAP,CC,Cov+ kind). - Add testcase-level
<system-out>diagnostics containing the same detailed diagnostic text already used for failure/skipped bodies. - Update unit/integration tests and README documentation to reflect the new JUnit XML shape.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Documents the new GitLab-friendly JUnit testcase naming and testcase-level system-out diagnostics. |
| core/src/main/java/media/barney/crap/core/ReportFormatter.java | Adds metric summary to testcase names and emits testcase-level system-out while preserving existing failure/skipped text and properties. |
| core/src/test/java/media/barney/crap/core/ReportFormatterTest.java | Updates formatter tests to assert the new testcase name shape and the presence/content of testcase-level system-out. |
| core/src/test/java/media/barney/crap/core/MainTest.java | Updates integration assertions to match the new testcase name format in the JUnit sidecar. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #197