Skip to content

EXPLORER_DB_CONNECTIONS_ENABLED does not seem to do anything? #705

@adam-hrb

Description

@adam-hrb

I have a basic setup with a single Django db connection being used by SQL explorer, so I would like to disable the DatabaseConnections management part.

Looking at the documentation https://django-sql-explorer.readthedocs.io/en/latest/settings.html#user-configured-db-connections and the code - it should be off by default as the setting EXPLORER_DB_CONNECTIONS_ENABLED is set to false ... but it's not really utilized anywhere in the code.

The simple fix would be to expose the endpoints urlpatterns += ee_urls' in explorer/urls.py:49' only if the setting is on,
but seeing also that explorer/views/mixins.py:21 populates EXPLORER_DB_CONNECTIONS_ENABLE into property db_connections_enabled (that is just not used anywhere I can find) - I am not really sure what was the plan here.

I am running the latest version: django-sql-explorer==5.3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions