Skip to content

Commit f1e677d

Browse files
fix: fix and cleanup metrics (sequencers + block) (#2904)
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview ref: #2896 (comment) Cleanup and remove confusing (and unused) metrics <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> --> --------- Co-authored-by: tac0turtle <marko@baricevic.me>
1 parent ded4f34 commit f1e677d

File tree

11 files changed

+28
-691
lines changed

11 files changed

+28
-691
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3636

3737
- **BREAKING:** Removed `evnode.v1.HealthService` gRPC endpoint. Use HTTP endpoints: `GET /health/live` and `GET /health/ready`. ([#2800](https://github.com/evstack/ev-node/pull/2800))
3838
- **BREAKING:** Removed `TrustedHash` configuration option and `--evnode.node.trusted_hash` flag. Sync service now automatically determines starting height from local store state ([#2838](https://github.com/evstack/ev-node/pull/2838))
39+
- **BREAKING:** Removed unused and confusing metrics from sequencers and block processing, including sequencer-specific metrics (gas price, blob size, transaction status, pending blocks), channel buffer metrics, overly granular error metrics, block production categorization metrics, and sync lag metrics. Essential metrics for DA submission health, block production, and performance monitoring are retained. [#2904](https://github.com/evstack/ev-node/pull/2904)
3940

4041
### Fixed
4142

apps/evm/cmd/run.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -111,19 +111,13 @@ func createSequencer(
111111
nodeConfig config.Config,
112112
genesis genesis.Genesis,
113113
) (coresequencer.Sequencer, error) {
114-
singleMetrics, err := single.NopMetrics()
115-
if err != nil {
116-
return nil, fmt.Errorf("failed to create single sequencer metrics: %w", err)
117-
}
118-
119114
sequencer, err := single.NewSequencer(
120115
ctx,
121116
logger,
122117
datastore,
123118
da,
124119
[]byte(genesis.ChainID),
125120
nodeConfig.Node.BlockTime.Duration,
126-
singleMetrics,
127121
nodeConfig.Node.Aggregator,
128122
)
129123
if err != nil {

apps/grpc/cmd/run.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,19 +119,13 @@ func createSequencer(
119119
nodeConfig config.Config,
120120
genesis genesis.Genesis,
121121
) (coresequencer.Sequencer, error) {
122-
singleMetrics, err := single.NopMetrics()
123-
if err != nil {
124-
return nil, fmt.Errorf("failed to create single sequencer metrics: %w", err)
125-
}
126-
127122
sequencer, err := single.NewSequencer(
128123
ctx,
129124
logger,
130125
datastore,
131126
da,
132127
[]byte(genesis.ChainID),
133128
nodeConfig.Node.BlockTime.Duration,
134-
singleMetrics,
135129
nodeConfig.Node.Aggregator,
136130
)
137131
if err != nil {

apps/testapp/cmd/run.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,6 @@ var RunCmd = &cobra.Command{
6868
return err
6969
}
7070

71-
singleMetrics, err := single.NopMetrics()
72-
if err != nil {
73-
return err
74-
}
75-
7671
// Start the KV executor HTTP server
7772
if kvEndpoint != "" { // Only start if endpoint is provided
7873
httpServer := kvexecutor.NewHTTPServer(executor, kvEndpoint)
@@ -101,7 +96,6 @@ var RunCmd = &cobra.Command{
10196
&daJrpc.DA,
10297
[]byte(genesis.ChainID),
10398
nodeConfig.Node.BlockTime.Duration,
104-
singleMetrics,
10599
nodeConfig.Node.Aggregator,
106100
)
107101
if err != nil {

0 commit comments

Comments
 (0)