fix: go lint issues

Author: CaelRowley

block/internal/cache/manager_test.go

@@ -563,11 +563,11 @@ func TestManager_PendingSignedHeader_NilHeaderIgnored(t *testing.T) {
 	_, _, ok := m.GetPendingSignedHeader(5)
 	require.False(t, ok)
 
-	real := signedHeaderForHeight(5, 0x01)
-	m.SetPendingSignedHeader(real, "p2p")
+	hdr := signedHeaderForHeight(5, 0x01)
+	m.SetPendingSignedHeader(hdr, "p2p")
 	got, _, ok := m.GetPendingSignedHeader(5)
 	require.True(t, ok)
-	require.Equal(t, real.Hash().String(), got.Hash().String())
+	require.Equal(t, hdr.Hash().String(), got.Hash().String())
 }
 
 func TestManager_GetPendingSignedHeader_Miss(t *testing.T) {

block/internal/syncing/doublesign_test.go

@@ -542,8 +542,8 @@ func TestDARetriever_DoubleSignEvidenceHasMatchingProposers(t *testing.T) {
 
 	captured := env.captured()
 	require.Len(t, captured, 1)
-	require.Equal(t, env.gen.ProposerAddress, []byte(captured[0].FirstHeader.ProposerAddress))
-	require.Equal(t, env.gen.ProposerAddress, []byte(captured[0].AlternateHeader.ProposerAddress))
+	require.Equal(t, env.gen.ProposerAddress, captured[0].FirstHeader.ProposerAddress)
+	require.Equal(t, env.gen.ProposerAddress, captured[0].AlternateHeader.ProposerAddress)
 }
 
 func TestSyncer_EvictsPendingHeaderOnPersist(t *testing.T) {

block/internal/syncing/p2p_handler.go

@@ -98,7 +98,7 @@ func (h *P2PHandler) ProcessHeight(ctx context.Context, height uint64, heightInC
 
 	// ValidateBasic is the precondition for treating an alternate as evidence.
 	if h.detectDoubleSign != nil {
-		if err := p2pHeader.SignedHeader.ValidateBasic(); err != nil {
+		if err := p2pHeader.ValidateBasic(); err != nil {
 			h.logger.Debug().Uint64("height", height).Err(err).Msg("invalid signed header from P2P")
 			return err
 		}