Skip to content

Commit d2f0943

Browse files
committed
wording
1 parent 5985a11 commit d2f0943

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

block/internal/syncing/syncer.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -815,7 +815,6 @@ func (s *Syncer) getEffectiveGracePeriod() uint64 {
815815
// Note: Due to block size constraints (MaxBytes), sequencers may defer forced inclusion transactions
816816
// to future blocks (smoothing). This is legitimate behavior within an epoch.
817817
// However, ALL forced inclusion txs from an epoch MUST be included before the next epoch begins or grace boundary (whichever comes later).
818-
// verifyForcedInclusionTxs checks if all forced inclusion transactions from DA are present in the block
819818
func (s *Syncer) verifyForcedInclusionTxs(currentState types.State, data *types.Data) error {
820819
if s.fiRetriever == nil {
821820
return nil
@@ -881,7 +880,7 @@ func (s *Syncer) verifyForcedInclusionTxs(currentState types.State, data *types.
881880

882881
// Check if we've moved past any epoch boundaries with pending txs
883882
// Grace period: Allow forced inclusion txs from epoch N to be included in epoch N+1, N+2, etc.
884-
// Only flag as malicious if past grace boundary to prevent false positives during DA unavailability.
883+
// Only flag as malicious if past grace boundary to prevent false positives during chain congestion.
885884
var maliciousTxs, remainingPending []pendingForcedInclusionTx
886885
var txsInGracePeriod int
887886
for _, pending := range stillPending {

docs/adr/adr-019-forced-inclusion-mechanism.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ func (s *Syncer) verifyForcedInclusionTxs(currentState State, data *Data) error
348348
}
349349

350350
// 5. Check for malicious behavior: pending txs past their grace boundary
351-
// Grace period provides tolerance for temporary DA unavailability
351+
// Grace period provides tolerance for temporary chain congestion
352352
var maliciousTxs, remainingPending []pendingForcedInclusionTx
353353
for _, pending := range stillPending {
354354
// Calculate grace boundary: epoch end + (effective grace periods × epoch size)
@@ -797,7 +797,7 @@ Accepted and Implemented
797797
8. **Robust Size Handling**: Two-tier size validation prevents DoS and DA rejections
798798
9. **Transaction Preservation**: All valid transactions are preserved in queues, nothing is lost
799799
10. **Strict MaxBytes Compliance**: Batches never exceed limits, preventing DA submission failures
800-
11. **DA Fault Tolerance**: Grace period prevents false positives during temporary DA unavailability
800+
11. **DA Fault Tolerance**: Grace period prevents false positives during temporary chain congestion
801801

802802
### Negative
803803

test/docker-e2e/resiliency_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@ package docker_e2e
55
import (
66
"context"
77
"fmt"
8-
tastoratypes "github.com/celestiaorg/tastora/framework/types"
98
"io"
109
"strings"
1110
"testing"
1211
"time"
1312

13+
tastoratypes "github.com/celestiaorg/tastora/framework/types"
14+
1415
da "github.com/celestiaorg/tastora/framework/docker/dataavailability"
1516
"github.com/celestiaorg/tastora/framework/docker/evstack"
1617
"github.com/docker/docker/api/types/container"

0 commit comments

Comments
 (0)