remove extra readonly opener

Author: tac0turtle

pkg/cmd/store.go

@@ -71,9 +71,7 @@ var StoreP2PInspectCmd = &cobra.Command{
 	Use:   "store-info",
 	Short: "Inspect the go-header (P2P) stores and display their tail/head entries",
 	Long: `Opens the datastore used by the node's go-header services and reports
-the current height, head, and tail information for both the header and data stores.
-The datastore is opened in read-only mode so that it can run against mounted snapshots
-or other read-only environments without requiring write access.`,
+the current height, head, and tail information for both the header and data stores.`,
 	RunE: func(cmd *cobra.Command, args []string) error {
 		nodeConfig, err := ParseConfig(cmd)
 		if err != nil {
@@ -87,7 +85,7 @@ or other read-only environments without requiring write access.`,
 
 		dbName := resolveDBName(cmd)
 
-		rawStore, err := store.NewDefaultReadOnlyKVStore(nodeConfig.RootDir, nodeConfig.DBPath, dbName)
+		rawStore, err := store.NewDefaultKVStore(nodeConfig.RootDir, nodeConfig.DBPath, dbName)
 		if err != nil {
 			return fmt.Errorf("failed to open datastore: %w", err)
 		}

pkg/store/kv.go

@@ -13,22 +13,8 @@ import (
 
 // NewDefaultKVStore creates instance of default key-value store.
 func NewDefaultKVStore(rootDir, dbPath, dbName string) (ds.Batching, error) {
-	return newDefaultKVStore(rootDir, dbPath, dbName, nil)
-}
-
-// NewDefaultReadOnlyKVStore creates a key-value store opened in badger's read-only mode.
-//
-// This is useful for tools that only inspect state (such as store-info) where the
-// underlying data directory might be mounted read-only.
-func NewDefaultReadOnlyKVStore(rootDir, dbPath, dbName string) (ds.Batching, error) {
-	opts := badger4.DefaultOptions
-	opts.Options = opts.Options.WithReadOnly(true)
-	return newDefaultKVStore(rootDir, dbPath, dbName, &opts)
-}
-
-func newDefaultKVStore(rootDir, dbPath, dbName string, options *badger4.Options) (ds.Batching, error) {
 	path := filepath.Join(rootify(rootDir, dbPath), dbName)
-	return badger4.NewDatastore(path, options)
+	return badger4.NewDatastore(path, nil)
 }
 
 // PrefixEntries retrieves all entries in the datastore whose keys have the supplied prefix