fix: path when genesis file already exists. (#2361)

Fix incorrect use of `homePath` for genesis file path.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved handling of genesis file paths by consistently using the
explicit genesis file location in messages and file operations across
multiple components.
- **New Features**
- Added a utility to generate the full path to the genesis file from the
home directory.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Marko <marko@baricevic.me>

Author: adlerjohn

apps/evm/based/cmd/init.go

@@ -62,17 +62,18 @@ func InitCmd() *cobra.Command {
 
 			// Initialize genesis without app state
 			err = rollgenesis.CreateGenesis(homePath, chainID, 1, proposerAddress)
+			genesisPath := rollgenesis.GenesisPath(homePath)
 			if errors.Is(err, rollgenesis.ErrGenesisExists) {
 				// check if existing genesis file is valid
-				if genesis, err := rollgenesis.LoadGenesis(homePath); err == nil {
+				if genesis, err := rollgenesis.LoadGenesis(genesisPath); err == nil {
 					if err := genesis.Validate(); err != nil {
 						return fmt.Errorf("existing genesis file is invalid: %w", err)
 					}
 				} else {
 					return fmt.Errorf("error loading existing genesis file: %w", err)
 				}
 
-				cmd.Printf("Genesis file already exists at %s, skipping creation.\n", homePath)
+				cmd.Printf("Genesis file already exists at %s, skipping creation.\n", genesisPath)
 			} else if err != nil {
 				return fmt.Errorf("error initializing genesis file: %w", err)
 			}

apps/evm/single/cmd/init.go

@@ -62,17 +62,18 @@ func InitCmd() *cobra.Command {
 
 			// Initialize genesis without app state
 			err = rollgenesis.CreateGenesis(homePath, chainID, 1, proposerAddress)
+			genesisPath := rollgenesis.GenesisPath(homePath)
 			if errors.Is(err, rollgenesis.ErrGenesisExists) {
 				// check if existing genesis file is valid
-				if genesis, err := rollgenesis.LoadGenesis(homePath); err == nil {
+				if genesis, err := rollgenesis.LoadGenesis(genesisPath); err == nil {
 					if err := genesis.Validate(); err != nil {
 						return fmt.Errorf("existing genesis file is invalid: %w", err)
 					}
 				} else {
 					return fmt.Errorf("error loading existing genesis file: %w", err)
 				}
 
-				cmd.Printf("Genesis file already exists at %s, skipping creation.\n", homePath)
+				cmd.Printf("Genesis file already exists at %s, skipping creation.\n", genesisPath)
 			} else if err != nil {
 				return fmt.Errorf("error initializing genesis file: %w", err)
 			}

apps/testapp/cmd/init.go

@@ -62,17 +62,18 @@ func InitCmd() *cobra.Command {
 
 			// Initialize genesis without app state
 			err = rollgenesis.CreateGenesis(homePath, chainID, 1, proposerAddress)
+			genesisPath := rollgenesis.GenesisPath(homePath)
 			if errors.Is(err, rollgenesis.ErrGenesisExists) {
 				// check if existing genesis file is valid
-				if genesis, err := rollgenesis.LoadGenesis(homePath); err == nil {
+				if genesis, err := rollgenesis.LoadGenesis(genesisPath); err == nil {
 					if err := genesis.Validate(); err != nil {
 						return fmt.Errorf("existing genesis file is invalid: %w", err)
 					}
 				} else {
 					return fmt.Errorf("error loading existing genesis file: %w", err)
 				}
 
-				cmd.Printf("Genesis file already exists at %s, skipping creation.\n", homePath)
+				cmd.Printf("Genesis file already exists at %s, skipping creation.\n", genesisPath)
 			} else if err != nil {
 				return fmt.Errorf("error initializing genesis file: %w", err)
 			}

pkg/genesis/io.go

@@ -10,6 +10,12 @@ import (
 
 var ErrGenesisExists = fmt.Errorf("genesis file already exists")
 
+// GenesisPath returns the genesis file path from a home directory.
+func GenesisPath(homePath string) string {
+	configDir := filepath.Join(homePath, "config")
+	return filepath.Join(configDir, "genesis.json")
+}
+
 // CreateGenesis creates and saves a genesis file with the given app state.
 // If the genesis file already exists, it skips the creation and returns ErrGenesisExists.
 // The genesis file is saved in the config directory of the specified home path.