fix: fix and cleanup metrics (sequencers + block)

Author: julienrbrt

apps/evm/cmd/run.go

@@ -111,19 +111,13 @@ func createSequencer(
 	nodeConfig config.Config,
 	genesis genesis.Genesis,
 ) (coresequencer.Sequencer, error) {
-	singleMetrics, err := single.NopMetrics()
-	if err != nil {
-		return nil, fmt.Errorf("failed to create single sequencer metrics: %w", err)
-	}
-
 	sequencer, err := single.NewSequencer(
 		ctx,
 		logger,
 		datastore,
 		da,
 		[]byte(genesis.ChainID),
 		nodeConfig.Node.BlockTime.Duration,
-		singleMetrics,
 		nodeConfig.Node.Aggregator,
 	)
 	if err != nil {

apps/grpc/cmd/run.go

@@ -119,19 +119,13 @@ func createSequencer(
 	nodeConfig config.Config,
 	genesis genesis.Genesis,
 ) (coresequencer.Sequencer, error) {
-	singleMetrics, err := single.NopMetrics()
-	if err != nil {
-		return nil, fmt.Errorf("failed to create single sequencer metrics: %w", err)
-	}
-
 	sequencer, err := single.NewSequencer(
 		ctx,
 		logger,
 		datastore,
 		da,
 		[]byte(genesis.ChainID),
 		nodeConfig.Node.BlockTime.Duration,
-		singleMetrics,
 		nodeConfig.Node.Aggregator,
 	)
 	if err != nil {

apps/testapp/cmd/run.go

@@ -68,11 +68,6 @@ var RunCmd = &cobra.Command{
 			return err
 		}
 
-		singleMetrics, err := single.NopMetrics()
-		if err != nil {
-			return err
-		}
-
 		// Start the KV executor HTTP server
 		if kvEndpoint != "" { // Only start if endpoint is provided
 			httpServer := kvexecutor.NewHTTPServer(executor, kvEndpoint)
@@ -101,7 +96,6 @@ var RunCmd = &cobra.Command{
 			&daJrpc.DA,
 			[]byte(genesis.ChainID),
 			nodeConfig.Node.BlockTime.Duration,
-			singleMetrics,
 			nodeConfig.Node.Aggregator,
 		)
 		if err != nil {

sequencers/single/metrics.go

@@ -31,10 +31,7 @@ type Sequencer struct {
 	da coreda.DA
 
 	batchTime time.Duration
-
-	queue *BatchQueue // single queue for immediate availability
-
-	metrics *Metrics
+	queue     *BatchQueue // single queue for immediate availability
 }
 
 // NewSequencer creates a new Single Sequencer
@@ -45,10 +42,9 @@ func NewSequencer(
 	da coreda.DA,
 	id []byte,
 	batchTime time.Duration,
-	metrics *Metrics,
 	proposer bool,
 ) (*Sequencer, error) {
-	return NewSequencerWithQueueSize(ctx, logger, db, da, id, batchTime, metrics, proposer, 1000)
+	return NewSequencerWithQueueSize(ctx, logger, db, da, id, batchTime, proposer, 1000)
 }
 
 // NewSequencerWithQueueSize creates a new Single Sequencer with configurable queue size
@@ -59,7 +55,6 @@ func NewSequencerWithQueueSize(
 	da coreda.DA,
 	id []byte,
 	batchTime time.Duration,
-	metrics *Metrics,
 	proposer bool,
 	maxQueueSize int,
 ) (*Sequencer, error) {
@@ -69,7 +64,6 @@ func NewSequencerWithQueueSize(
 		batchTime: batchTime,
 		Id:        id,
 		queue:     NewBatchQueue(db, "batches", maxQueueSize),
-		metrics:   metrics,
 		proposer:  proposer,
 	}
 
@@ -128,18 +122,6 @@ func (c *Sequencer) GetNextBatch(ctx context.Context, req coresequencer.GetNextB
 	}, nil
 }
 
-// RecordMetrics updates the metrics with the given values.
-// This method is intended to be called by the block manager after submitting data to the DA layer.
-func (c *Sequencer) RecordMetrics(gasPrice float64, blobSize uint64, statusCode coreda.StatusCode, numPendingBlocks uint64, includedBlockHeight uint64) {
-	if c.metrics != nil {
-		c.metrics.GasPrice.Set(gasPrice)
-		c.metrics.LastBlobSize.Set(float64(blobSize))
-		c.metrics.TransactionStatus.With("status", fmt.Sprintf("%d", statusCode)).Add(1)
-		c.metrics.NumPendingBlocks.Set(float64(numPendingBlocks))
-		c.metrics.IncludedBlockHeight.Set(float64(includedBlockHeight))
-	}
-}
-
 // VerifyBatch implements sequencing.Sequencer.
 func (c *Sequencer) VerifyBatch(ctx context.Context, req coresequencer.VerifyBatchRequest) (*coresequencer.VerifyBatchResponse, error) {
 	if !c.isValid(req.Id) {